From: Stephan Mueller <smueller@chronox.de>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: Juan Manuel Torres Palma <j.m.torrespalma@gmail.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
davem@davemloft.net, herbert@gondor.apana.org.au
Subject: Re: [PATCH] crypto: testmgr: add test vectors for skein
Date: Wed, 20 Jun 2018 20:26:34 +0200 [thread overview]
Message-ID: <1602937.V4TYxMrJ9m@tauon.chronox.de> (raw)
In-Reply-To: <20180620175638.GB76265@gmail.com>
Am Mittwoch, 20. Juni 2018, 19:56:38 CEST schrieb Eric Biggers:
Hi Eric,
> > + .alg = "skein1024",
> > + .test = alg_test_hash,
> > + .fips_allowed = 1,
>
> Are you sure Skein should be on the "FIPS allowed" list? I'm not
> particularly familiar with FIPS, but my understanding is that the
> fips_allowed flag is only supposed to be set on specific "approved"
> algorithms. So if you're unsure, it shouldn't be set.
Skein is definitely not allowed in FIPS mode. Please drop that flag.
>
> Eric
Ciao
Stephan
next prev parent reply other threads:[~2018-06-20 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 10:57 Juan Manuel Torres Palma
2018-06-20 17:56 ` Eric Biggers
2018-06-20 18:26 ` Stephan Mueller [this message]
2018-06-20 18:10 ` Eric Biggers
2018-06-20 22:12 ` Juan Manuel Torres Palma
2018-06-20 23:27 ` Eric Biggers
2018-07-01 9:16 ` Herbert Xu
2018-07-01 9:47 ` Greg Kroah-Hartman
2018-07-01 16:32 ` Jason Cooper
2018-07-01 18:48 ` [PATCH] staging/skein: Remove Skein and Threefish code Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1602937.V4TYxMrJ9m@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=davem@davemloft.net \
--cc=ebiggers3@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=j.m.torrespalma@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®