From: don-linux@isis.cs3-inc.com (Don Cohen)
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: proposed optimization for network drivers
Date: Fri, 18 Apr 2003 09:22:50 -0700 [thread overview]
Message-ID: <16032.9818.987823.826601@isis.cs3-inc.com> (raw)
In-Reply-To: <20030418.085933.131914868.davem@redhat.com>
David S. Miller writes:
> From: don-linux@isis.cs3-inc.com (Don Cohen)
> Date: Fri, 18 Apr 2003 08:37:01 -0700
>
> For instance, why does every driver have to call
> eth_type_trans? Could that be delayed for netif_rx ?
>
> Silly example. Ethernet specific routines do not belong in
> device generic netif_rx().
Ok, fair enough.
How about the larger point that it's reasonable to check early whether
the labor you're about to expend will be wasted and the suggestion
that this be encapsulated in a function that all drivers can share?
next prev parent reply other threads:[~2003-04-18 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-17 6:56 Don Cohen
2003-04-18 8:36 ` David S. Miller
2003-04-18 15:37 ` Don Cohen
2003-04-18 15:59 ` David S. Miller
2003-04-18 16:22 ` Don Cohen [this message]
2003-04-18 17:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16032.9818.987823.826601@isis.cs3-inc.com \
--to=don-linux@isis.cs3-inc.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®