From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752226Ab3ERJHk (ORCPT ); Sat, 18 May 2013 05:07:40 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:59866 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606Ab3ERJHi (ORCPT ); Sat, 18 May 2013 05:07:38 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com Subject: Re: [PATCH 0/3] CPUFreq Fixes for 3.10-rc2 Date: Sat, 18 May 2013 11:16:13 +0200 Message-ID: <1603621.USQfKr7LjW@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.9.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: <3949011.nZfu3g41l4@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, May 18, 2013 07:45:45 AM Viresh Kumar wrote: > On 18 May 2013 05:10, Rafael J. Wysocki wrote: > > Well, I actually meant "can you please verify your belief?". :-) > > > > And that's because I'm wondering why the zero-day build testing doesn't > > catch this problem. Apparently, it doesn't build .configs with cpufreq > > governors configured as modules, although I believe it does test > > "make allmodconfig" for a couple of architectures at least. What gives? > > My assumption was wrong. Actually cpufreq_governor.c is never compiled > as module, but cpufreq_ondemand is... > > And this routine isn't used from cpufreq_ondemand but cpufreq_governor.. > > But we were lucky that we didn't get a error here and EXPORT_SYMBOL > is still required :) Although not necessarily 3.10 material I suppose? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.