From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028AbeBHKBV (ORCPT ); Thu, 8 Feb 2018 05:01:21 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:42806 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbeBHKBS (ORCPT ); Thu, 8 Feb 2018 05:01:18 -0500 From: "Rafael J. Wysocki" To: Kai-Heng Feng Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI / battery: Add quirk for Asus UX360UA and UX410UAK Date: Thu, 08 Feb 2018 10:59:35 +0100 Message-ID: <1603805.FnSEaBbLeX@aspire.rjw.lan> In-Reply-To: <20180129054036.13599-1-kai.heng.feng@canonical.com> References: <20180129054036.13599-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, January 29, 2018 6:40:36 AM CET Kai-Heng Feng wrote: > Same issue as other Asus laptops, ACPI incorrectly reports discharging > when battery is full and AC is plugged. > > Use the same battery quirk can workaround the issue. > > BugLink: https://bugs.launchpad.net/bugs/1661876 > BugLink: https://bugs.launchpad.net/bugs/1745032 > Signed-off-by: Kai-Heng Feng > --- > drivers/acpi/battery.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c > index 19bc440820e6..7128488a3a72 100644 > --- a/drivers/acpi/battery.c > +++ b/drivers/acpi/battery.c > @@ -1209,6 +1209,22 @@ static const struct dmi_system_id bat_dmi_table[] __initconst = { > DMI_MATCH(DMI_PRODUCT_NAME, "UX305LA"), > }, > }, > + { > + .callback = battery_full_discharging_quirk, > + .ident = "ASUS UX360UA", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "UX360UA"), > + }, > + }, > + { > + .callback = battery_full_discharging_quirk, > + .ident = "ASUS UX410UAK", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "UX410UAK"), > + }, > + }, > {}, > }; > > Applied, thanks!