From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754035AbdKMRUT (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Nov 2017 12:20:19 -0500
Received: from mailout3.samsung.com ([203.254.224.33]:52277 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753949AbdKMRUQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Nov 2017 12:20:16 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171113172014epoutp0366cbcfa14bf00411fcfe291075e88807~2tOOl0CIq1068710687epoutp03J
X-AuditID: b6c32a48-905ff7000000103e-cd-5a09d44e6b17
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] fbcon: Initialize ops->info early
Date: Mon, 13 Nov 2017 18:20:11 +0100
Message-id: <1603816.FMahT1RJZd@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <20171113094546.16593-1-thierry.reding@gmail.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7bCmha7fFc4og/Yz0hZXvr5nszjTnWtx
        ou8Dq8XlXXPYLH7umsfiwOoxu+Eii8fOWXfZPe53H2fy+LxJLoAlissmJTUnsyy1SN8ugStj
        +fEP7AVL2Svubt7G2sDYxtbFyMkhIWAiMbPvNWsXIxeHkMAORokJbzqgnO+MEq+7PwJVcYBV
        LZrADBHfwCjx/N4TFgjnK6PE4flbWEFGsQlYSUxsX8UIYosI6Er8P/0GrIhZoJlR4lvrDLCE
        sICZRMP8TUwgNouAqsSUQ8fYQTbwCmhKNLeXg4RFBbwktuxrByvhFLCTeDHnEDuIzSsgKPFj
        8j0WEJtZQF5i3/6prBC2jsTZY+sYId7ZwCZxdiofhO0i8XneTKg3hSVeHd/CDmFLSzxbtRGq
        fjqjxPbfEiB3SghsZpRYtXsCVJG1xOHjF6EW8El0HP7LDgkJXomONiGIEg+JP+dPMkHYjhLz
        N/RAQ2gio8Svg59YJzDKzkJy9ywkd89CcvcCRuZVjGKpBcW56anFRgUmesWJucWleel6yfm5
        mxjBSUDLYwfjgXM+hxgFOBiVeHhfXOSMEmJNLCuuzD3EKMHBrCTC+2kdUIg3JbGyKrUoP76o
        NCe1+BCjNAeLkjhv3bZrEUIC6YklqdmpqQWpRTBZJg5OqQbGw90RsU+yg886fFZR+b33M+/L
        B31tcWIdG2au7Uy5mCCdWDe148DTLYe2zjmwJoNN/o4f/9HrCh7GR9dcmSgcv+/7eu1/fRZP
        PCJOaXk5rHBPXHx/Z3+u4syL+39MvarhE7W9r0ci9SGj/iqpMoa5JVvO/KldPO+h7fRNxf/6
        HLaEMZ2T9a3KVmIpzkg01GIuKk4EAPvEKF3+AgAA
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t9jQV3fK5xRBs++Wlpc+fqezeJMd67F
        ib4PrBaXd81hs/i5ax6LA6vH7IaLLB47Z91l97jffZzJ4/MmuQCWKC6blNSczLLUIn27BK6M
        5cc/sBcsZa+4u3kbawNjG1sXIweHhICJxKIJzF2MXBxCAusYJabf38cI4XxllLjce5S9i5GT
        g03ASmJi+ypGEFtEQFfi/+k3LCBFzALNjBKbf3axgiSEBcwkGuZvYgKxWQRUJaYcOsYOsoFX
        QFOiub0cJCwq4CWxZV87WAmngJ3EizmH2CGWTWaUuN/zhxkkwSsgKPFj8j0WEJtZQF5i3/6p
        rBC2lsT6nceZJjDyz0JSNgtJ2SwkZQsYmVcxSqYWFOem5xYbFRjlpZbrFSfmFpfmpesl5+du
        YgSG7bbDWv07GB8viT/EKMDBqMTDe+IKR5QQa2JZcWXuIUYJDmYlEd5P6zijhHhTEiurUovy
        44tKc1KLDzFKc7AoifPy5x+LFBJITyxJzU5NLUgtgskycXBKNTC2TK5ZO+mE5+SEj0IbjYt+
        qh6uUnnVYrlkfVD9VPO3nO9yaiOfZv3ZGr7apqqU4wLHhTlbVvmolyh1NxZ/MXm40dCRkZXH
        u371ifK8HoFe39WNqclzFdn2sm0MupYkuevdlDmbWZZ2KaeEu86Seld1aGFPnR/TYaf7LQ+O
        FRcn/o80aSlb26LEUpyRaKjFXFScCACbFWZAVwIAAA==
X-CMS-MailID: 20171113172014epcas2p363dab7ac9841273481463c61f967d204
X-Msg-Generator: CA
CMS-TYPE: 102P
X-CMS-RootMailID: 20171113094554epcas3p2eb67a3b7263176dfabc719e3bddb792c
X-RootMTR: 20171113094554epcas3p2eb67a3b7263176dfabc719e3bddb792c
References: <CGME20171113094554epcas3p2eb67a3b7263176dfabc719e3bddb792c@epcas3p2.samsung.com>
        <20171113094546.16593-1-thierry.reding@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, November 13, 2017 10:45:46 AM Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> During console takeover, which happens for all DRM/KMS setups using the
> fbdev helpers, fbcon_startup() is called before fbcon_init() and as a
> result con2fb_acquire_newinfo() will not be called (info->fbcon_par was
> set to non-NULL in fbcon_startup()) to assign ops->info.
> 
> This causes the cursor_timer_handler() to unreference a NULL pointer.
> 
> Avoid this by unconditionally assigning ops->info during fbcon_startup()
> so that it will be available early, but keep the additional assignment
> in con2fb_acquire_newinfo() to support console remapping at runtime.
> 
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Patch queued for 4.15, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics