From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E330C388F7 for ; Thu, 29 Oct 2020 00:58:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E76620791 for ; Thu, 29 Oct 2020 00:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603933096; bh=G+a9tAqKfo1FKngndd1wk/6n9OaUyZGsZA67OwoudG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Pks2L2xJ8t3FphDFG2Da1lAcjhLuAWHrRTOFpXhYMbzdp2dh2xlBrwrusDpbVRGru 75QDIpXvjrMxTUEM6g0sEakJslh5aUbQ6Qz4Yu3CfzAa7+D4mzsOnIYZOqM4Nskd1r OCHRRGbuawK2qzmhaEcrXackC3Tl6LRtUYf6lQCw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403929AbgJ2A6O (ORCPT ); Wed, 28 Oct 2020 20:58:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:60546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731587AbgJ1WRc (ORCPT ); Wed, 28 Oct 2020 18:17:32 -0400 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEE64247B4; Wed, 28 Oct 2020 15:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603897968; bh=G+a9tAqKfo1FKngndd1wk/6n9OaUyZGsZA67OwoudG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uqaV11gbUEV4zvNXiGpLI51CWpkthZ3eLlf/UK+rqHMVIQdd7836W3aMcVJEDUn4O anOuCYwDkUXDOpbLFVxImekHbJ/q1bzMz8j7Fh/k2EiUj8xw7IfaI54bfHElMNmZxD nwldbbREuijDa/Si90aWB+aAFtbbED3tbxzlP0rw= From: Will Deacon To: Ard Biesheuvel , linux-kernel@vger.kernel.org Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , Geert Uytterhoeven , Kees Cook , Nick Desaulniers , linux-arm-kernel@lists.infradead.org, Jessica Yu Subject: Re: [PATCH] module: use hidden visibility for weak symbol references Date: Wed, 28 Oct 2020 15:12:34 +0000 Message-Id: <160389413619.1112960.12611093041695506337.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201027151132.14066-1-ardb@kernel.org> References: <20201027151132.14066-1-ardb@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Oct 2020 16:11:32 +0100, Ard Biesheuvel wrote: > Geert reports that commit be2881824ae9eb92 ("arm64/build: Assert for > unwanted sections") results in build errors on arm64 for configurations > that have CONFIG_MODULES disabled. > > The commit in question added ASSERT()s to the arm64 linker script to > ensure that linker generated sections such as .got, .plt etc are empty, > but as it turns out, there are corner cases where the linker does emit > content into those sections. More specifically, weak references to > function symbols (which can remain unsatisfied, and can therefore not > be emitted as relative references) will be emitted as GOT and PLT > entries when linking the kernel in PIE mode (which is the case when > CONFIG_RELOCATABLE is enabled, which is on by default). > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] module: use hidden visibility for weak symbol references https://git.kernel.org/arm64/c/13150bc5416f Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev