mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@linux.alibaba.com>
To: davem@davemloft.net
Cc: Jakub Kicinski <kuba@kernel.org>,
	Tom Parkin <tparkin@katalix.com>,
	James Chapman <jchapman@katalix.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] net/l2tp: remove unused macros to tame gcc warning
Date: Fri,  6 Nov 2020 13:29:54 +0800	[thread overview]
Message-ID: <1604640594-5750-1-git-send-email-alex.shi@linux.alibaba.com> (raw)

There some unused macros cause gcc complain:

net/l2tp/l2tp_core.c:73:0: warning: macro "L2TP_HDRFLAG_P" is not used
[-Wunused-macros]
net/l2tp/l2tp_core.c:80:0: warning: macro "L2TP_SLFLAG_S" is not used
[-Wunused-macros]
net/l2tp/l2tp_core.c:81:0: warning: macro "L2TP_SL_SEQ_MASK" is not used
[-Wunused-macros]

Let's remove them to tame gcc.

Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: "David S. Miller" <davem@davemloft.net> 
Cc: Jakub Kicinski <kuba@kernel.org> 
Cc: Tom Parkin <tparkin@katalix.com> 
Cc: James Chapman <jchapman@katalix.com> 
Cc: netdev@vger.kernel.org 
Cc: linux-kernel@vger.kernel.org 
---
 net/l2tp/l2tp_core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index 7be5103ff2a8..672a53f602b5 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -73,16 +73,11 @@
 #define L2TP_HDRFLAG_L	   0x4000
 #define L2TP_HDRFLAG_S	   0x0800
 #define L2TP_HDRFLAG_O	   0x0200
-#define L2TP_HDRFLAG_P	   0x0100
 
 #define L2TP_HDR_VER_MASK  0x000F
 #define L2TP_HDR_VER_2	   0x0002
 #define L2TP_HDR_VER_3	   0x0003
 
-/* L2TPv3 default L2-specific sublayer */
-#define L2TP_SLFLAG_S	   0x40000000
-#define L2TP_SL_SEQ_MASK   0x00ffffff
-
 #define L2TP_HDR_SIZE_MAX		14
 
 /* Default trace flags */
-- 
1.8.3.1


                 reply	other threads:[~2020-11-06  5:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1604640594-5750-1-git-send-email-alex.shi@linux.alibaba.com \
    --to=alex.shi@linux.alibaba.com \
    --cc=davem@davemloft.net \
    --cc=jchapman@katalix.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tparkin@katalix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®