From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Kevin Hilman <khilman@linaro.org>
Subject: Re: [PATCH V2 0/3] PM: Enable option of re-use runtime PM callbacks at system suspend
Date: Fri, 20 Dec 2013 14:18:22 +0100 [thread overview]
Message-ID: <1605004.ViTQsllvdk@vostro.rjw.lan> (raw)
In-Reply-To: <CAPDyKFrS6k1Zd5=XQX4ODk2=obo89bk-Z6aJvv+3WsrHw3nGbg@mail.gmail.com>
On Friday, December 20, 2013 09:43:16 AM Ulf Hansson wrote:
> On 10 December 2013 14:37, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > To put devices into low power state during system suspend, it is convenient
> > for some runtime PM supported power domains, subsystems and drivers to have
> > the option of re-using and invoking the runtime PM callbacks from their system
> > PM callbacks.
> >
> > The benefit is that we don't need to implement wrapper functions which
> > handles runtime PM resourses, typically called from both runtime PM and system
> > PM callbacks.
> >
> > Some new helper macros for defining the PM callbacks are added.
> >
> > SET_PM_RUNTIME_PM_OPS; to define runtime PM callbacks for CONFIG_PM instead of
> > CONFIG_PM_RUNTIME.
> >
> > SET_LATE_SYSTEM_SLEEP_PM_OPS; to define common late/early system PM callbacks,
> > same approach is applicable to the existing SET_SYSTEM_SLEEP_PM_OPS which
> > defines common suspend/resume system PM callbacks.
> >
> > A minor fix was needed for the platform bus, which runtime PM callbacks are set
> > to the pm_generic_runtime_suspend|resume functions. These were implemented only
> > for CONFIG_PM_RUNTIME and thus the platform bus prevented driver's runtime PM
> > callbacks to be invoked when only CONFIG_PM_SLEEP was used. We move them into
> > CONFIG_PM to resolve the problem.
> >
> > Changes in v2:
> > Updated commit messages to try to better reflect the changes.
> > Removed the below patches from this patch set. Let's leave those to be
> > addressed separately, if needed.
> > - PM / Sleep: Add pm_generic functions to re-use runtime PM callbacks
> > - drm/exynos: Convert to suspend_late/resume_early callbacks for fimc
> >
> >
> > Ulf Hansson (3):
> > PM / Runtime: Add second macro for definition of runtime PM callbacks
> > PM / Runtime: Implement the pm_generic_runtime functions for
> > CONFIG_PM
> > PM / Sleep: Add macro to define common late/early system PM callbacks
> >
> > drivers/base/power/generic_ops.c | 4 ++--
> > include/linux/pm.h | 21 +++++++++++++++++++++
> > include/linux/pm_runtime.h | 12 ++++++++----
> > 3 files changed, 31 insertions(+), 6 deletions(-)
> >
> > --
> > 1.7.9.5
> >
>
> Hi,
>
> Just wanted to send a kind ping on this patchset.
>
> Would be nice to try to conclude on the way forward after the quite
> long and good discussions we had around this topic.
Sorry, I was traveling last week. I'm processing my backlog now, hopefully
I'll get to your patches shortly.
Thanks,
Rafael
next prev parent reply other threads:[~2013-12-20 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 13:37 Ulf Hansson
2013-12-10 13:37 ` [PATCH V2 1/3] PM / Runtime: Add second macro for definition of runtime PM callbacks Ulf Hansson
2013-12-10 13:37 ` [PATCH V2 2/3] PM / Runtime: Implement the pm_generic_runtime functions for CONFIG_PM Ulf Hansson
2013-12-10 13:37 ` [PATCH V2 3/3] PM / Sleep: Add macro to define common late/early system PM callbacks Ulf Hansson
2013-12-20 8:43 ` [PATCH V2 0/3] PM: Enable option of re-use runtime PM callbacks at system suspend Ulf Hansson
2013-12-20 13:18 ` Rafael J. Wysocki [this message]
2013-12-22 1:01 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605004.ViTQsllvdk@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®