From: xiakaixu1987@gmail.com
To: kishon@ti.com, vkoul@kernel.org
Cc: linux-kernel@vger.kernel.org, Kaixu Xia <kaixuxia@tencent.com>
Subject: [PATCH] phy: mapphone-mdm6600: remove the unused variable error value assignment
Date: Fri, 13 Nov 2020 16:34:42 +0800 [thread overview]
Message-ID: <1605256482-5101-1-git-send-email-kaixuxia@tencent.com> (raw)
From: Kaixu Xia <kaixuxia@tencent.com>
The value of variable error is overwritten by the following call
devm_request_threaded_irq() in phy_mdm6600_device_power_on(), so here the
value assignment is useless. Remove it.
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
drivers/phy/motorola/phy-mapphone-mdm6600.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c
index 5172971..24ab848 100644
--- a/drivers/phy/motorola/phy-mapphone-mdm6600.c
+++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
@@ -421,7 +421,6 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata)
dev_info(ddata->dev, "Powered up OK\n");
} else {
ddata->enabled = false;
- error = -ETIMEDOUT;
dev_err(ddata->dev, "Timed out powering up\n");
}
--
1.8.3.1
next reply other threads:[~2020-11-13 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 8:34 xiakaixu1987 [this message]
2020-11-16 7:48 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605256482-5101-1-git-send-email-kaixuxia@tencent.com \
--to=xiakaixu1987@gmail.com \
--cc=kaixuxia@tencent.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®