From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C7C5C55ABD for ; Fri, 13 Nov 2020 15:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2E6F22249 for ; Fri, 13 Nov 2020 15:21:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="eTXstJfy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbgKMPVY (ORCPT ); Fri, 13 Nov 2020 10:21:24 -0500 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:51695 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbgKMPVX (ORCPT ); Fri, 13 Nov 2020 10:21:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1605280883; x=1636816883; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=b/5OjSM9VK1XMAdLydktZ7tDE6fgDTRGJoBG4hNXffM=; b=eTXstJfyNu4Q3k4wqf36ams2E+70+u67DUItjUXeeswoOns8QobecUmM E4ujlIvEeRBS9wCSckcQ6O47ptb0Mfzm+vL0+vtuB7JjDxxJEN5Kjl/cH 00gcpn1ppHxDELOjfnT8p4wSN9TllqkuwiWX/Qnz8pUxd873aBwWgkPzM xITBsRAqG9p6g41zLSZXj1IKKcqKO67RXkNVPqNNmMg2mY47v51a3sFVX 1GTURWuyKRm3dj0I+csw8xDbmoKFTyjZqKgD5qykt7vv6hq53mzC3hH5+ J5TmaaVmuC5qpaeuJBNI8hBHr9RZ4MnH/C28NBK99Wi5m71+ox3iZzk16 w==; IronPort-SDR: IwrEie/D51TUBqmvPqmLaMpbC6si7Uke5nKRz1buYHsojR8qFLQzUV8kDMhssuoqt23/VaYHFV x5Rv425AoOcCQhLGFr8RcOC1ed05TB04xxmKgTa2Fbl+hyPEdnOipcnnPm8NBvz4iA9w6ReX5v dod1ll6wRkx1HD6M7HCumP521I6xBx4ou2J8XwL8JMgmcKWZ/qa7biDCSbW8dAeUj5n4Bn8GIl qVHfrfVgKIrls2dmqzsrvV/zBAJEaMSXwAoLfa4hahckg+/calOIZ8n5OwNteMzrvxoy+cZgx8 tuc= X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="98340440" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Nov 2020 08:21:23 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Fri, 13 Nov 2020 08:21:22 -0700 Received: from m18063-ThinkPad-T460p.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Fri, 13 Nov 2020 08:21:18 -0700 From: Claudiu Beznea To: , CC: , , , , , , Claudiu Beznea Subject: [PATCH v3 1/6] regulator: core: validate selector against linear_min_sel Date: Fri, 13 Nov 2020 17:21:05 +0200 Message-ID: <1605280870-32432-2-git-send-email-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1605280870-32432-1-git-send-email-claudiu.beznea@microchip.com> References: <1605280870-32432-1-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are regulators who's min selector is not zero. Selectors loops (looping b/w zero and regulator::desc::n_voltages) might throw errors because invalid selectors are used (lower than regulator::desc::linear_min_sel). For this situations validate selectors against regulator::desc::linear_min_sel. Fixes: 3a40cfc36bb3d ("regulator: core: create unlocked version of regulator_list_voltage") Fixes: 04eca28cde52c ("regulator: Add helpers for low-level register access") Fixes: 88cd222b259d6 ("regulator: provide consumer interface for fall/rise time") Fixes: d295f7670127e ("regulator: core: Move list_voltage_{linear,linear_range,table} to helpers.c") Signed-off-by: Claudiu Beznea --- drivers/regulator/core.c | 9 +++++++-- drivers/regulator/helpers.c | 3 ++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 2e1ea18221ef..1d0d35f14f37 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2958,7 +2958,8 @@ static int _regulator_list_voltage(struct regulator_dev *rdev, return rdev->desc->fixed_uV; if (ops->list_voltage) { - if (selector >= rdev->desc->n_voltages) + if (selector >= rdev->desc->n_voltages || + selector < rdev->desc->linear_min_sel) return -EINVAL; if (lock) regulator_lock(rdev); @@ -3109,7 +3110,8 @@ int regulator_list_hardware_vsel(struct regulator *regulator, struct regulator_dev *rdev = regulator->rdev; const struct regulator_ops *ops = rdev->desc->ops; - if (selector >= rdev->desc->n_voltages) + if (selector >= rdev->desc->n_voltages || + selector < rdev->desc->linear_min_sel) return -EINVAL; if (ops->set_voltage_sel != regulator_set_voltage_sel_regmap) return -EOPNOTSUPP; @@ -4032,6 +4034,9 @@ int regulator_set_voltage_time(struct regulator *regulator, for (i = 0; i < rdev->desc->n_voltages; i++) { /* We only look for exact voltage matches here */ + if (i < rdev->desc->linear_min_sel) + continue; + voltage = regulator_list_voltage(regulator, i); if (voltage < 0) return -EINVAL; diff --git a/drivers/regulator/helpers.c b/drivers/regulator/helpers.c index e4bb09bbd3fa..974f1a63993d 100644 --- a/drivers/regulator/helpers.c +++ b/drivers/regulator/helpers.c @@ -647,7 +647,8 @@ int regulator_list_voltage_table(struct regulator_dev *rdev, return -EINVAL; } - if (selector >= rdev->desc->n_voltages) + if (selector >= rdev->desc->n_voltages || + selector < rdev->desc->linear_min_sel) return -EINVAL; return rdev->desc->volt_table[selector]; -- 2.7.4