From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477AbdKLAOZ (ORCPT ); Sat, 11 Nov 2017 19:14:25 -0500 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:48441 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbdKLAOX (ORCPT ); Sat, 11 Nov 2017 19:14:23 -0500 From: "Rafael J. Wysocki" To: Sinan Kaya Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, linux-arm-msm , linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com, linux-kernel@vger.kernel.org, "linux-acpi@vger.kernel.org" Subject: Re: [PATCH V3 2/4] ACPI / bus: introduce acpi_device_get_match_data() function Date: Sun, 12 Nov 2017 01:14:12 +0100 Message-ID: <1605519.pfaIp4IsxJ@aspire.rjw.lan> In-Reply-To: <31ef1ea5-ddb6-1a24-980b-7986627cfeca@codeaurora.org> References: <1510281175-27173-1-git-send-email-okaya@codeaurora.org> <1510281175-27173-2-git-send-email-okaya@codeaurora.org> <31ef1ea5-ddb6-1a24-980b-7986627cfeca@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, November 10, 2017 3:35:41 AM CET Sinan Kaya wrote: > +linux-acpi@vger.kernel.org, +Rafael Thanks! > On 11/9/2017 9:32 PM, Sinan Kaya wrote: > > OF has of_device_get_match_data() function to extract driver specific data > > structure. Add a similar function for ACPI. > > > > Signed-off-by: Sinan Kaya > > --- > > drivers/acpi/bus.c | 12 ++++++++++++ > > include/linux/acpi.h | 6 ++++++ > > 2 files changed, 18 insertions(+) > > > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > index 4d0979e..da29c10 100644 > > --- a/drivers/acpi/bus.c > > +++ b/drivers/acpi/bus.c > > @@ -785,6 +785,18 @@ const struct acpi_device_id *acpi_match_device(const struct acpi_device_id *ids, > > } > > EXPORT_SYMBOL_GPL(acpi_match_device); > > > > +void *acpi_device_get_match_data(const struct device *dev) > > +{ > > + const struct acpi_device_id *match; > > + > > + match = acpi_match_device(dev->driver->acpi_match_table, dev); > > + if (!match) > > + return NULL; > > + > > + return (void *)match->driver_data; > > +} > > +EXPORT_SYMBOL_GPL(acpi_device_get_match_data); While I understand that the name follows the OF convention, I have some doubts on whether it is the best one. Apart from this the change is fine by me. Thanks, Rafael