From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13BFC338586 for ; Thu, 4 Dec 2025 13:27:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764854834; cv=none; b=tWbTe5totnVrN4/iIZ3eTqyoC08g4zCbY+A1e32L/N5d74L3xeM56Ib7J+IE7PkqG/OFSaiLyv8k0OhjugQbnbdCKj41AlDy9yEaVH98q1A7BxrrJg74+IiE/dLMdJavPvo7Hl6adAGMLdDt0N84aI/V4IFrTrpvNH1ALcBDLrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764854834; c=relaxed/simple; bh=TX2aNn6Txc21R7wkZRHglMy5X17XWRqN8kc9m8eWEl0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KeAOTuY/4hYU6+j+d/J6ybBJP6g7FbTxt/9Uhw/0Bp/tmMSnUW/At+njWW6Y8E02V4eklvytna10MnVcqzI8DMxBh2CaJSHc3eKJYA4YibY/9hgKOOEek5rP+0sGDaAJ1mfHNH9fQjtTMdo7iIa+WSDilvo8ZFLyp4Vr7er7hJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=atdcpNZ7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DiagKW+P; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="atdcpNZ7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DiagKW+P" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B4AErjY1275608 for ; Thu, 4 Dec 2025 13:27:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J3BEgiMQNQBWEFBBbvKgKwnhgWUoTYK3fDTHRMW620o=; b=atdcpNZ7ElN5oCUw ivDmCWB+Qq0UBG67GdOxXAGrFh0ZXkZZbGxiMZb41K2LKiOzMdo0/8cvySdmtq9k Aaa2eChW04GWGi2fnIhO19ro3fCk1XGKPP19BuW7lUPbVwp0nupMbs9iB8LDY6ou 8SlgPZ1Db0+p/o9O2Om5fEItuB6gHD7kW8l52vUiB7VZuSueyr3XmK+3dRLvDJWB WHfQgK6rC/P0mYsyzG0/dQVDahZseqeZXgcNxyOCLwJ9YZ6LznzzBy8StiXI4nas Q+LiCKnNmKEg9uKXHNUXvHmOS6sPNTLCdTxSD+VLhxpoFIUL/yxvqaJeDXw0rgU+ SYRdzw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4au6uvrvwv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Dec 2025 13:27:11 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b23452ec2bso4873385a.1 for ; Thu, 04 Dec 2025 05:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764854831; x=1765459631; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J3BEgiMQNQBWEFBBbvKgKwnhgWUoTYK3fDTHRMW620o=; b=DiagKW+PtwavHKhU9K8Gw3Gp87Bo8xyHHoy/W8V8WtuiGzr//c5MytilOEnUT7snbG v1uYUBDF5WFBZHJxMG1uPcj5epJQcKhYQQjpKrQ2TCtqveSGXgRS4+s0DaUgbMAvrjcf mbWF9vuG7xDw1ztHXB4P84P5ksF8tVT0uv7c1MnyQMLSnFn61ngfBCmF2eu7rAsrkvQj OA94489a9sI3z7GGwgNtaaiM+Tjo3oFAFfpnD20f/Pke95lNUTpMXetdH4BMOUf1/oRs IMslk0EFUReus9J62MH5gVdH0glnrC9G/Xfozi4jzHVlSG45uNO+ACcji/7b3WjoP8Sn t3IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764854831; x=1765459631; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J3BEgiMQNQBWEFBBbvKgKwnhgWUoTYK3fDTHRMW620o=; b=n1ehdGTF8c5Cm0y4AowxouOI9nvDjN8ViRENwlyDdf4tfU6rO7lHt9Nqj5NXSfi7SW CabvPThV73pp365IPRoyLmL0mbigRlgPKFPvGryuvrYy6ibL8QcGELSgcCeu98QhTF9u Yvit50eCbzdQRrdwCQSO0l3aMWrEldNURFRpqcrc/B6ZHf4fD8fAa839m9lLeBp7LE3w D+I+ILFDz7dnEKzPueMRvGe80jvrDM5krwu+ko/kS0J64U84nWvMF5k+GJOqNN+JeG/Y UgBRhoYwfwvGDZx8tGMj6L9pL7DrNea+DI57WXGryGKeOkRk71IEEpBqB5W+H6AE+rN9 4j6A== X-Forwarded-Encrypted: i=1; AJvYcCV4B4g8FgyDJMj6FPf2y4VeXG6yCpKqTQTuoS+Rf+u2nmsxtWXoSEgcFbN85CziBAQgE6v370tahl/2tms=@vger.kernel.org X-Gm-Message-State: AOJu0YxYEjVNKYkHz4Rk/8KIYEWWaM0kVbCTxAuDvqoT7dxTJntfE+P8 qUoP83vCtgOAOqSqJLsmLkwv/dE3Ljzbwiof/0eY31ZuU9A9JwQMmmU3CBri8c5dF9HjcgEpDD+ fE3z2z8hIupjMAFXKKlvtf9EVN0fGlWlmVaaUi4Jca3hHgm/uPuh6OPTsSZUFl534IfY= X-Gm-Gg: ASbGnct9h4dSaVxFtthHXjZwgDTOv4yaP48ZWR3Zr+tq5+76sQuB5cQFyLimUZuwTKs jkdgF/LppXPLNSOA/jbPcUjYH4silpHLJGoDP+Zem+deoZLgXY91srs4WwEx+wpuniE+xvQ8WP1 Lo0iDrEwYH+4lgheU78i9w+RK0AyNX/WpHJyjg6Pv7pNVGiroeVTUr8ahnPy6MrAO7DwKkMGz6l GwEhM84/QWsAApoA8fM+e7SEVQfFzbKMsSYlrftHFXRCvWGKCc3uWIyrgIguOx2jszziF/NxuUe v5m0KKYJEvzuquhr/fchk0EPXB2M3austckKXalF4GcMd//KJZIyMgD+p/j1ua4WvHn1vBx9179 LyJf92w9EegFdUL2Qrciugl9/KYRlPYPjEHMQiNd1T/geNs9C8cuqfsLgWi/5pjRGRQ== X-Received: by 2002:a05:620a:1985:b0:8b1:a4dd:3d66 with SMTP id af79cd13be357-8b5f8bffce1mr551525785a.1.1764854831140; Thu, 04 Dec 2025 05:27:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGh56UAJuRB86lSXEDyhdK2SsF2SVo4nMmW49ZdAwHGuURV14ptAGvZyHWhSX4g7LeBXYetPA== X-Received: by 2002:a05:620a:1985:b0:8b1:a4dd:3d66 with SMTP id af79cd13be357-8b5f8bffce1mr551521785a.1.1764854830596; Thu, 04 Dec 2025 05:27:10 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-647b368dcf8sm1271135a12.19.2025.12.04.05.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 05:27:10 -0800 (PST) Message-ID: <1605571d-9199-41f9-9624-305357324b1b@oss.qualcomm.com> Date: Thu, 4 Dec 2025 14:27:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties To: Krzysztof Kozlowski , Paul Sajna , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Heidelberg Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Amir Dahan , Christopher Brown , Dmitry Baryshkov References: <20251203-judyln-dts-v5-0-80c1ffca8487@postmarketos.org> <20251203-judyln-dts-v5-1-80c1ffca8487@postmarketos.org> <6ebf4056-c6e0-495b-9e67-ca8d9dc8eae3@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6ebf4056-c6e0-495b-9e67-ca8d9dc8eae3@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA0MDEwOSBTYWx0ZWRfX+/9U/lEza1qR mDiDURHGnzbj/Me7enlaKcqRLUdV29GlL4cfT9TheqS/Vbxe1QFFLnvthP1q/glckvJSuzsaKMn bRLv3QilYZuYt4CImfXonHs3ulsBhYyJkXap/61CZywoPngyaef4Ggyn/D+gcUWp9E0KpC99bpk cJQqMaQ66immhbw8/oFGqyuVwHQsbECBWnaRfJuNslxtzYRDRSuE4Xkqjt5XjyV86BiCwTUKC7Z RVzHG+dUyEaErMqLGjlDHQiT9NHfHJQbsy2M2Bg5whP87BhCZeOK/0Lk3w9iWf86yTDQ4EGvkul ofmmtYJi0vu9uegqZtzMZq+EhXmChVOB4C4f3bdE/Dm+Oftx4EYG+ym3cPGy7YIGQ4Rtms3rpN2 ucMPxBfjtoRdsQM4N4H652BtIxZ1tQ== X-Authority-Analysis: v=2.4 cv=d7n4CBjE c=1 sm=1 tr=0 ts=69318c2f cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Gbw9aFdXAAAA:8 a=9YTxGxaVBTEbm7DE2cgA:9 a=QEXdDO2ut3YA:10 a=5XHQ0vS7sDUA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=9vIz8raoGPyDa4jBFAYH:22 X-Proofpoint-ORIG-GUID: RHXGaT0jDYBY-D6u1YBgNw95arUPK0pg X-Proofpoint-GUID: RHXGaT0jDYBY-D6u1YBgNw95arUPK0pg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-04_03,2025-12-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512040109 On 12/4/25 2:11 PM, Krzysztof Kozlowski wrote: > On 03/12/2025 10:40, Paul Sajna wrote: >> Improve adherance to style guidelines below: >> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html >> >> Reviewed-by: Konrad Dybcio >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Paul Sajna >> --- >> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 144 ++++++++++++++----------- >> 1 file changed, 82 insertions(+), 62 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi >> index 0ee2f4b99fbd..b8ab64a8de1c 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi >> @@ -38,11 +38,6 @@ reserved-memory { >> #size-cells = <2>; >> ranges; >> >> - qseecom_mem: memory@b2000000 { >> - reg = <0 0xb2000000 0 0x1800000>; >> - no-map; >> - }; >> - >> gpu_mem: memory@8c415000 { >> reg = <0 0x8c415000 0 0x2000>; >> no-map; >> @@ -99,7 +94,12 @@ memory@9d400000 { >> no-map; >> }; >> >> - rmtfs_mem: rmtfs-region@f0800000 { > > Why? > >> + qseecom_mem: memory@b2000000 { >> + reg = <0 0xb2000000 0 0x1800000>; >> + no-map; >> + }; >> + >> + rmtfs_mem: memory@f0801000 { > > No, you are doing much more then sorting. You are changing names to > incorrect ones and maybe (tricky to say) change also unit address to > buggy one. > > @Konrad, > Why are we started resorting the addresses BEFORE we came up with proper > linter? Why the rule suddenly changed? I don't really mind small cleanups that are done as part of bigger feature additions, as opposed to fixing a single file for the sake of it Konrad