From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
ast@kernel.org, daniel@iogearbox.net, songliubraving@fb.com,
andrii.nakryiko@gmail.com, torvalds@linux-foundation.org,
kernel-team@fb.com
Subject: Re: [PATCH bpf v7 0/2] Fix bpf_probe_read_user_str() overcopying
Date: Thu, 19 Nov 2020 19:00:05 +0000 [thread overview]
Message-ID: <160581240571.6156.14990667088525286782.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <cover.1605642949.git.dxu@dxuuu.xyz>
Hello:
This series was applied to bpf/bpf.git (refs/heads/master):
On Tue, 17 Nov 2020 12:05:44 -0800 you wrote:
> 6ae08ae3dea2 ("bpf: Add probe_read_{user, kernel} and probe_read_{user,
> kernel}_str helpers") introduced a subtle bug where
> bpf_probe_read_user_str() would potentially copy a few extra bytes after
> the NUL terminator.
>
> This issue is particularly nefarious when strings are used as map keys,
> as seemingly identical strings can occupy multiple entries in a map.
>
> [...]
Here is the summary with links:
- [bpf,v7,1/2] lib/strncpy_from_user.c: Don't overcopy bytes after NUL terminator
https://git.kernel.org/bpf/bpf/c/33b97ea52713
- [bpf,v7,2/2] selftest/bpf: Test bpf_probe_read_user_str() strips trailing bytes after NUL
https://git.kernel.org/bpf/bpf/c/a8005439fc81
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2020-11-19 19:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 20:05 Daniel Xu
2020-11-17 20:05 ` [PATCH bpf v7 1/2] lib/strncpy_from_user.c: Don't overcopy bytes after NUL terminator Daniel Xu
2020-11-17 20:14 ` Alexei Starovoitov
2020-11-19 18:33 ` Alexei Starovoitov
2020-11-19 18:40 ` Linus Torvalds
2020-11-19 18:44 ` Alexei Starovoitov
2020-11-17 20:05 ` [PATCH bpf v7 2/2] selftest/bpf: Test bpf_probe_read_user_str() strips trailing bytes after NUL Daniel Xu
2020-11-19 19:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160581240571.6156.14990667088525286782.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dxu@dxuuu.xyz \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome