From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A01A383A14; Fri, 16 Aug 2024 06:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723791578; cv=none; b=eTF81euMjjeLojevYN03b3S8rT+O5evFj6AoKQ51ChRAtI+L+FjWtr8rjNAWZST+wSn+eV7i2d3UG8mZ4cB29FEJp74UTItWN+7JGrinnaFSgkTv2CKA0892ikw43bNRm1Tsr+FQadO7+d0JlnJlJLC1HXE75QNqCMNXkyFChEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723791578; c=relaxed/simple; bh=oLjXu0BovmzaiWPPZC3G1gHwyZLxFoPoULSAR07tyZc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rbaG633wEvvv/N7QQoNvRUWs/ohLliw8yIEcixXM4QvqcYdA/3YTYXrEZeRcI2gutD0R2gwSfi5xpU3aYADsYS0MH5V07LvP1hticM5gI55GjjzJtO2JaM8FAuJhQhPzTDnXKpCrog0Qtnw99g3FXa/EtDE6n00XpH2pcjpoq/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8C8D143D; Fri, 16 Aug 2024 00:00:01 -0700 (PDT) Received: from [192.168.1.13] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 582E23F58B; Thu, 15 Aug 2024 23:59:30 -0700 (PDT) Message-ID: <1605d622-faf5-4535-bd71-ba514ee102dd@arm.com> Date: Fri, 16 Aug 2024 08:59:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 6/6] rust: cpufreq: Add rust implementation of cppc_cpufreq driver To: Miguel Ojeda , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Viresh Kumar , Robert Moore , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Martin Rodriguez Reboredo , Manos Pitsidianakis , Mika Westerberg , FUJITA Tomonori , Thomas Bertschinger , Danilo Krummrich , linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, acpica-devel@lists.linux.dev, rust-for-linux@vger.kernel.org, Metin Kaya References: <20240815082916.1210110-1-pierre.gondois@arm.com> <20240815082916.1210110-7-pierre.gondois@arm.com> Content-Language: en-US From: Pierre Gondois In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Greg, Miguel, On 8/15/24 15:04, Miguel Ojeda wrote: > On Thu, Aug 15, 2024 at 10:31 AM Pierre Gondois wrote: >> >> In an effort to add test/support the cpufreq framework in rust, >> add a rust implementation of the cppc_cpufreq driver named: >> `rcppc_cpufreq`. > > Similar to what Greg said -- is this intended to be something like a > "Rust reference driver" [1] for the subsystem? The initial intent was to review/test Viresh's patchset [1]. I then thought it would be a good idea to implement another cpufreq driver to see if the provided interface would work. As the cpufreq-dt driver is re-implemented in Viresh's patchset, I thought it was also ok to have this driver. > > [1] https://rust-for-linux.com/rust-reference-drivers > >> + depends on ACPI_PROCESSOR >> + depends on ARM || ARM64 || RISCV > Yes right > `depends on RUST`? > > Also, I imagine you skipped all safety comments etc. since it is an > RFC, but I thought I would mention it nevertheless. Ok, if it is decided not to drop this patchset, I ll add some comments, > > Thanks for experimenting with Rust! > > Cheers, > Miguel Regards, Pierre