From: Marc Zyngier <maz@kernel.org>
To: Xu Qiang <xuqiang36@huawei.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de
Cc: rui.xiang@huawei.com
Subject: Re: [PATCH -next] irq-chip/gic-v3-its: Fixed an issue where the ITS executes the residual commands in the queue again when the ITS wakes up from sleep mode.
Date: Sun, 22 Nov 2020 12:47:48 +0000 [thread overview]
Message-ID: <160604923575.224052.1351706430622290182.b4-ty@kernel.org> (raw)
In-Reply-To: <20201107104226.14282-1-xuqiang36@huawei.com>
On Sat, 7 Nov 2020 10:42:26 +0000, Xu Qiang wrote:
> On my platform, ITS_FLAGS_SAVE_SUSPEND_STATE is not set,thus do nothing
> in its suspend and resuse function.On the other hand,firmware stores
> GITS_CTRL,GITS_CBASER,GITS_CWRITER and GITS_BASER<n> in the suspend,
> and restores these registers in the resume. As a result, the ITS executes
> the residual commands in the queue.
>
> Memory corruption may occur in the following scenarios:
>
> [...]
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/gic-v3-its: Unconditionally save/restore the ITS state on suspend
commit: a51f7296f38f498c6f186c82ae3aa25ae10bb266
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2020-11-22 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 10:42 Xu Qiang
2020-11-07 16:54 ` Marc Zyngier
2020-11-09 3:05 ` xuqiang (M)
2020-11-09 10:43 ` Marc Zyngier
2020-11-10 9:09 ` xuqiang (M)
2020-11-17 13:37 ` xuqiang (M)
2020-11-22 12:47 ` Marc Zyngier [this message]
2020-11-23 16:45 ` [irqchip: irq/irqchip-next] irqchip/gic-v3-its: Unconditionally save/restore the ITS state on suspend irqchip-bot for Xu Qiang
-- strict thread matches above, loose matches on Subject: below --
2020-11-03 8:11 [PATCH -next] irq-chip/gic-v3-its: Fixed an issue where the ITS executes the residual commands in the queue again when the ITS wakes up from sleep mode Xu Qiang
2020-11-03 18:19 ` Marc Zyngier
2020-11-05 11:54 ` xuqiang (M)
2020-11-05 13:12 ` Marc Zyngier
2020-11-05 14:06 ` xuqiang (M)
2020-11-05 14:24 ` Marc Zyngier
2020-11-06 10:05 ` xuqiang (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160604923575.224052.1351706430622290182.b4-ty@kernel.org \
--to=maz@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.xiang@huawei.com \
--cc=tglx@linutronix.de \
--cc=xuqiang36@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®