From: " donmor" <donmor3000@hotmail.com>
To: "Markus.Elfring@web.de" <Markus.Elfring@web.de>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"chenhuacai@kernel.org" <chenhuacai@kernel.org>,
"loongarch@lists.linux.dev" <loongarch@lists.linux.dev>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@xen0n.name" <kernel@xen0n.name>
Subject: Re: [PATCH] loongarch: Fix broken CONFIG_CMDLINE (RESEND 2)
Date: Sun, 9 Jul 2023 13:43:31 +0000 [thread overview]
Message-ID: <160653e3eefb53d00c3bb17aa803b4f12569de50.camel@hotmail.com> (raw)
In-Reply-To: <6011256b-f4a9-a410-dc62-cb7a308bf07f@web.de>
在 2023-07-09星期日的 14:56 +0200，Markus Elfring写道：
> > This patch tends to fix CONFIG_CMDLINE, which is not working with
> > CONFIG_CMDLINE_EXTEND or CONFIG_CMDLINE_BOOTLOADER. Some code is absent
> > in
> > arch/loongarch/kernel/setup.c, which should handle built-in command
> > lines
> > in CONFIG_CMDLINE. The absence of such code causes CONFIG_CMDLINE not
> > working if CONFIG_CMDLINE_EXTEND or CONFIG_CMDLINE_BOOTLOADER is set to
> > Y.
> …
>
> Please choose an imperative change suggestion.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94
>
>
> > Signed-off-by: donmor <donmor3000@hotmail.com>
>
> Would a more unique real name be more appropriate here?
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n411
>
> Regards,
> Markus
I'll resend this patch. It may be a new conversation since the subject has been changed.
Sorry for resending twice because Outlook Web messed my mail up.
prev parent reply other threads:[~2023-07-09 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 8:12 [PATCH] loongarch: Fix broken CONFIG_CMDLINE donmor
2023-07-09 8:25 ` WANG Xuerui
[not found] ` <6011256b-f4a9-a410-dc62-cb7a308bf07f@web.de>
2023-07-09 13:43 ` donmor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160653e3eefb53d00c3bb17aa803b4f12569de50.camel@hotmail.com \
--to=donmor3000@hotmail.com \
--cc=Markus.Elfring@web.de \
--cc=chenhuacai@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®