From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andrew Morton <akpm@digeo.com>
Cc: tytso@mit.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] htree nfs fix
Date: Wed, 14 May 2003 11:05:54 +0200 [thread overview]
Message-ID: <16066.1778.401988.753875@charged.uio.no> (raw)
In-Reply-To: <20030513174425.2bc49803.akpm@digeo.com>
>>>>> " " == Andrew Morton <akpm@digeo.com> writes:
> Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>>
>> If you're unhappy with the state of readdir, then fix the
>> VFS/glibc.
> What should be done?
Either we have to agree that we break legacy 32-bit getdents() and
treat all cookies as signed 32/64-bit, or we break getdents64(), and
treat all cookies as unsigned. (This applies to both 2.5.x and 2.4.x)
The former will (IIRC) break setups with those IRIX servers that like
to use 0xFFFFFFFF as an end-of-readdir marker. It also requires an
extra patch in order to mangle the otherwise unsigned NFS
cookies. (This patch has been ready but withheld from the official
kernel tree pending a decision on this issue for at least 2 years -
hence my irritation whenever this subject comes up)
The latter will break glibc, which likes to abuse getdents64() and
simply test for signed 32-bit overflow in place of using the 32-bit
getdents().
Cheers,
Trond
next prev parent reply other threads:[~2003-05-14 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 0:23 Trond Myklebust
2003-05-14 0:44 ` Andrew Morton
2003-05-14 9:05 ` Trond Myklebust [this message]
2003-05-14 9:12 ` Andrew Morton
2003-05-14 9:32 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16066.1778.401988.753875@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®