mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: mikpe@csd.uu.se
To: alexander.riesen@synopsys.COM
Cc: mikpe@csd.uu.se, linux-laptop@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: 2.5.69+bk: oops in apmd after waking up from suspend mode
Date: Wed, 14 May 2003 16:03:55 +0200	[thread overview]
Message-ID: <16066.19659.609760.316141@gargle.gargle.HOWL> (raw)
In-Reply-To: <20030514134600.GA16533@Synopsys.COM>

Alex Riesen writes:
 > mikpe@csd.uu.se, Wed, May 14, 2003 15:04:38 +0200:
 > > Since 2.5.69-bk8 or so, apm.c will invoke restore_processor_state()
 > > at resume-time. This is needed to reinitialise the SYSENTER MSRs
 > > used by 2.5's new system call mechanism.
 > 
 > and it supposed to go oops?

Of course not. It doesn't oops my Dell Latitude: on that laptop it
prevents oopses since otherwise user-space processes will oops the kernel
as soon as they make a system call or return from a system call. But this
only happens if both the CPU and glibc are capable of using SYSENTER.

 > >  >  <6>note: kapmd[4] exited with preempt_count 2
 > > This I don't like. I'm not convinced the resume path is preempt-safe.
 > > Please try again, either with CONFIG_PREEMPT disabled, or with a
 > > preempt_disable() / preempt_enable() pair around apm.c's suspend code,
 > > like in the patch below. (Untested, you may need to stick an #include
 > > <preempt.h> somewhere in apm.c to make it compile.)
 > 
 > It changed things a bit. preempt_count is 3 now.
 > Oops didn't change.

Ok so it wasn't preempt.
Can you identify in which statement the oops occurs?
And can you confirm that commenting out the calls in apm.c to
save_processor_state() and restore_processor_state() eliminates the oops?

/Mikael

  reply	other threads:[~2003-05-14 13:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-14  9:48 Alex Riesen
2003-05-14 13:04 ` mikpe
2003-05-14 13:46   ` Alex Riesen
2003-05-14 14:03     ` mikpe [this message]
2003-05-14 14:11       ` Alex Riesen
2003-05-14 14:37         ` mikpe
2003-05-14 14:45           ` Alex Riesen
2003-05-19 12:16 mikpe
2003-05-19 12:31 ` Alex Riesen
2003-05-19 14:41   ` Alex Riesen
2003-05-19 15:13     ` Alex Riesen
2003-05-20 10:39     ` Carl-Daniel Hailfinger
2003-05-20 10:48       ` Alex Riesen
2003-05-20 16:34       ` Milton Miller
2003-05-20 17:00         ` Alex Riesen
2003-05-20 17:17           ` Alex Riesen
2003-05-20 20:10             ` Nigel Cunningham
2003-05-20 22:01               ` Zwane Mwaikambo
2003-05-19 21:57 ` Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16066.19659.609760.316141@gargle.gargle.HOWL \
    --to=mikpe@csd.uu.se \
    --cc=alexander.riesen@synopsys.COM \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-laptop@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®