From: Paul Mackerras <paulus@samba.org>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: [PATCH] module owner for ppp_synctty.c
Date: Mon, 19 May 2003 14:39:56 +1000 [thread overview]
Message-ID: <16072.24604.834386.374479@argo.ozlabs.ibm.com> (raw)
This patch fixes ppp_synctty.c (used for doing PPP over some synchronous
serial HDLC links) so that it sets the owner field of the tty line
discipline it exports, rather than using MOD_INC/DEC_USE_COUNT. This
is more or less from Stephen Hemminger.
Please apply.
Thanks,
Paul.
diff -urN linux-2.5/drivers/net/ppp_synctty.c pmac-2.5/drivers/net/ppp_synctty.c
--- linux-2.5/drivers/net/ppp_synctty.c 2003-04-25 09:17:22.000000000 +1000
+++ pmac-2.5/drivers/net/ppp_synctty.c 2003-04-27 17:58:13.000000000 +1000
@@ -202,7 +202,6 @@
struct syncppp *ap;
int err;
- MOD_INC_USE_COUNT;
ap = kmalloc(sizeof(*ap), GFP_KERNEL);
err = -ENOMEM;
if (ap == 0)
@@ -236,7 +235,6 @@
out_free:
kfree(ap);
out:
- MOD_DEC_USE_COUNT;
return err;
}
@@ -276,7 +274,6 @@
if (ap->tpkt != 0)
kfree_skb(ap->tpkt);
kfree(ap);
- MOD_DEC_USE_COUNT;
}
/*
@@ -404,6 +401,7 @@
static struct tty_ldisc ppp_sync_ldisc = {
+ .owner = THIS_MODULE,
.magic = TTY_LDISC_MAGIC,
.name = "pppsync",
.open = ppp_sync_open,
reply other threads:[~2003-05-19 4:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16072.24604.834386.374479@argo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®