mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, benh@kernel.crashing.org,
	jgarzik@pobox.com
Subject: [PATCH] module refcounts for airport driver
Date: Mon, 19 May 2003 15:02:48 +1000	[thread overview]
Message-ID: <16072.25976.912797.769942@argo.ozlabs.ibm.com> (raw)

This patch takes out the MOD_INC/DEC_USE_COUNT in the airport (Apple
wireless ethernet) driver.  The driver already does SET_MODULE_OWNER
on the netdevice, so the MOD_INC/DEC_USE_COUNT are unnecessary and
just cause warnings.

Please apply.

Thanks,
Paul.

diff -urN linux-2.5/drivers/net/wireless/airport.c pmac-2.5/drivers/net/wireless/airport.c
--- linux-2.5/drivers/net/wireless/airport.c	2003-02-21 09:48:09.000000000 +1100
+++ pmac-2.5/drivers/net/wireless/airport.c	2003-04-23 22:04:33.000000000 +1000
@@ -275,15 +275,11 @@
 
 	printk(KERN_DEBUG "%s\n", version);
 
-	MOD_INC_USE_COUNT;
-
 	/* Lookup card in device tree */
 	airport_node = find_devices("radio");
 	if (airport_node && !strcmp(airport_node->parent->name, "mac-io"))
 		airport_dev = airport_attach(airport_node);
 
-	MOD_DEC_USE_COUNT;
-
 	return airport_dev ? 0 : -ENODEV;
 }
 

                 reply	other threads:[~2003-05-19  4:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16072.25976.912797.769942@argo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®