From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C323C4361B for ; Tue, 8 Dec 2020 17:11:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EB2523B03 for ; Tue, 8 Dec 2020 17:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730589AbgLHRLm (ORCPT ); Tue, 8 Dec 2020 12:11:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:51746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730253AbgLHRLm (ORCPT ); Tue, 8 Dec 2020 12:11:42 -0500 From: Mark Brown Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: Adam Ward , Support Opensource , Dan Carpenter Cc: Liam Girdwood , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: References: Subject: Re: [PATCH] regulator: da9121: Potential Oops in da9121_assign_chip_model() Message-Id: <160744745469.29972.2193088415551214848.b4-ty@kernel.org> Date: Tue, 08 Dec 2020 17:10:54 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Dec 2020 20:55:44 +0300, Dan Carpenter wrote: > There is a missing "return ret;" on this error path so we call > "da9121_check_device_type(i2c, chip);" which will end up dereferencing > "chip->regmap" and lead to an Oops. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] regulator: da9121: Potential Oops in da9121_assign_chip_model() commit: 8db06423e079b1f6c0657e5bebda0006acf75c3c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark