From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9339C4361B for ; Fri, 11 Dec 2020 15:37:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EFD923121 for ; Fri, 11 Dec 2020 15:37:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437617AbgLKPDq (ORCPT ); Fri, 11 Dec 2020 10:03:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:33308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437556AbgLKPDL (ORCPT ); Fri, 11 Dec 2020 10:03:11 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C97DD22B2E; Fri, 11 Dec 2020 15:01:56 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1knjvf-000TxV-1q; Fri, 11 Dec 2020 15:01:55 +0000 From: Marc Zyngier To: shawnguo@kernel.org, linux@rasmusvillemoes.dk, leoyang.li@nxp.com, mark.rutland@arm.com, zhiqiang.hou@nxp.com, Biwen Li , robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, Marc Zyngier Cc: xiaobo.xie@nxp.com, Hou Zhiqiang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Biwen Li , jiafei.pan@nxp.com, Tsahee Zidenberg , Antoine Tenart Subject: Re: [PATCH] irqchip/alpine-msi: Fix freeing of interrupts on allocation error path Date: Fri, 11 Dec 2020 15:01:40 +0000 Message-Id: <160769813659.482133.9468394664184226982.b4-ty@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201129135525.396671-1-maz@kernel.org> References: <20201129135525.396671-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: shawnguo@kernel.org, linux@rasmusvillemoes.dk, leoyang.li@nxp.com, mark.rutland@arm.com, zhiqiang.hou@nxp.com, biwen.li@oss.nxp.com, robh+dt@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, maz@kernel.org, xiaobo.xie@nxp.com, Zhiqiang.Hou@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, biwen.li@nxp.com, jiafei.pan@nxp.com, tsahee@annapurnalabs.com, atenart@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Nov 2020 13:55:25 +0000, Marc Zyngier wrote: > The alpine-msi driver has an interesting allocation error handling, > where it frees the same interrupts repeatedly. Hilarity follows. > > This code is probably never executed, but let's fix it nonetheless. Applied to irq/irqchip-next, thanks! [1/1] irqchip/alpine-msi: Fix freeing of interrupts on allocation error path commit: 3841245e8498a789c65dedd7ffa8fb2fee2c0684 Cheers, M. -- Without deviation from the norm, progress is not possible.