mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	tglx@linutronix.de, ludwig.nussel@suse.de,
	harvey.harrison@gmail.com, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mm] x86: Fix mmap random address range
Date: Wed, 07 Dec 2011 07:29:14 -0500	[thread overview]
Message-ID: <16078.1323260954@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 05 Dec 2011 09:52:17 PST." <tip-9af0c7a6fa860698d080481f24a342ba74b68982@git.kernel.org>

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

On Mon, 05 Dec 2011 09:52:17 PST, tip-bot for Ludwig Nussel said:
> Commit-ID:  9af0c7a6fa860698d080481f24a342ba74b68982
> Gitweb:     http://git.kernel.org/tip/9af0c7a6fa860698d080481f24a342ba74b68982
> Author:     Ludwig Nussel <ludwig.nussel@suse.de>
> AuthorDate: Tue, 15 Nov 2011 14:46:46 -0800
> Committer:  Ingo Molnar <mingo@elte.hu>
> CommitDate: Mon, 5 Dec 2011 17:07:23 +0100
>
> x86: Fix mmap random address range
>
> On x86_32 casting the unsigned int result of get_random_int() to
> long may result in a negative value.  On x86_32 the range of
> mmap_rnd() therefore was -255 to 255.  The 32bit mode on x86_64
> used 0 to 255 as intended.

Will somebody please hand me a big dose of caffeine and explain to me
how the range could have been -255 to 255?  -256 maybe, or -128 to 127,
but -255??!?

[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]

      reply	other threads:[~2011-12-07 12:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201111152246.pAFMklOB028527@wpaz5.hot.corp.google.com>
2011-12-05 17:52 ` tip-bot for Ludwig Nussel
2011-12-07 12:29   ` Valdis.Kletnieks [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16078.1323260954@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=harvey.harrison@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=ludwig.nussel@suse.de \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®