From: Paul Mackerras <paulus@samba.org>
To: James Simmons <jsimmons@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH] fix controlfb and platinumfb drivers
Date: Sat, 24 May 2003 21:40:05 +1000 [thread overview]
Message-ID: <16079.23061.979768.135318@argo.ozlabs.ibm.com> (raw)
James,
This patch fixes the controlfb and platinumfb drivers so that the
arguments to fb_set_var are in the correct order. Please apply.
Thanks,
Paul.
diff -urN linux-2.5/drivers/video/controlfb.c pmac-2.5/drivers/video/controlfb.c
--- linux-2.5/drivers/video/controlfb.c 2003-04-25 22:19:46.000000000 +1000
+++ pmac-2.5/drivers/video/controlfb.c 2003-05-21 13:32:42.000000000 +1000
@@ -475,7 +475,7 @@
/* Apply default var */
var.activate = FB_ACTIVATE_NOW;
- rc = fb_set_var(&var, &p->info);
+ rc = fb_set_var(&p->info, &var);
if (rc && (vmode != VMODE_640_480_60 || cmode != CMODE_8))
goto try_again;
diff -urN linux-2.5/drivers/video/platinumfb.c pmac-2.5/drivers/video/platinumfb.c
--- linux-2.5/drivers/video/platinumfb.c 2003-04-25 22:19:46.000000000 +1000
+++ pmac-2.5/drivers/video/platinumfb.c 2003-05-21 13:33:01.000000000 +1000
@@ -399,7 +399,7 @@
/* Apply default var */
p->info.var = var;
var.activate = FB_ACTIVATE_NOW;
- rc = fb_set_var(&var, &p->info);
+ rc = fb_set_var(&p->info, &var);
if (rc && (default_vmode != VMODE_640_480_60 || default_cmode != CMODE_8))
goto try_again;
next reply other threads:[~2003-05-24 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-24 11:40 Paul Mackerras [this message]
2003-05-27 22:29 ` [Linux-fbdev-devel] " James Simmons
2003-05-27 23:08 ` Paul Mackerras
2003-05-28 12:36 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16079.23061.979768.135318@argo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®