From: Defang Bo <bodefang@126.com>
To: agk@redhat.com, snitzer@redhat.com
Cc: linux-kernel@vger.kernel.org, Defang Bo <bodefang@126.com>
Subject: [PATCH] dm snap : add sanity checks to snapshot_ctr
Date: Fri, 25 Dec 2020 14:48:46 +0800 [thread overview]
Message-ID: <1608878926-2283057-1-git-send-email-bodefang@126.com> (raw)
Similar to commit<70de2cbd>,there should be a check for argc and argv to prevent Null pointer dereferencing
when the dm_get_device invoked twice on the same device path with differnt mode.
Signed-off-by: Defang Bo <bodefang@126.com>
---
drivers/md/dm-snap.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c
index 4668b2c..dccce8b 100644
--- a/drivers/md/dm-snap.c
+++ b/drivers/md/dm-snap.c
@@ -1258,6 +1258,13 @@ static int snapshot_ctr(struct dm_target *ti, unsigned int argc, char **argv)
as.argc = argc;
as.argv = argv;
+
+ if (!strcmp(argv[0], argv[1])) {
+ ti->error = "Error setting metadata or data device";
+ r = -EINVAL;
+ goto bad;
+ }
+
dm_consume_args(&as, 4);
r = parse_snapshot_features(&as, s, ti);
if (r)
--
2.7.4
next reply other threads:[~2020-12-25 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 6:48 Defang Bo [this message]
2021-01-04 20:27 ` Mike Snitzer
2020-12-28 2:55 [PATCH] " Defang Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608878926-2283057-1-git-send-email-bodefang@126.com \
--to=bodefang@126.com \
--cc=agk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®