From: Defang Bo <bodefang@126.com>
To: airlied@linux.ie, daniel@ffwll.ch, sumit.semwal@linaro.org
Cc: alexander.deucher@amd.com, christian.koenig@amd.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org, Defang Bo <bodefang@126.com>
Subject: [PATCH] drm/amd:avoid null pointer dereference when dev is not bound
Date: Sun, 27 Dec 2020 19:46:44 +0800 [thread overview]
Message-ID: <1609069604-3949767-1-git-send-email-bodefang@126.com> (raw)
[Why]
Similar to commit<0fa375e6>. If amdgpu_switcheroo_can_switch access
the drm_device when dev is not bound, a null pointer dereference can happen.
[How]
Add sanity checks to prevent it.
Signed-off-by: Defang Bo <bodefang@126.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 37da353..f70e528 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1439,6 +1439,9 @@ static void amdgpu_switcheroo_set_state(struct pci_dev *pdev,
static bool amdgpu_switcheroo_can_switch(struct pci_dev *pdev)
{
struct drm_device *dev = pci_get_drvdata(pdev);
+
+ if (!dev)
+ return false;
/*
* FIXME: open_count is protected by drm_global_mutex but that would lead to
--
2.7.4
reply other threads:[~2020-12-27 12:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609069604-3949767-1-git-send-email-bodefang@126.com \
--to=bodefang@126.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®