From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F718C433DB for ; Mon, 28 Dec 2020 03:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D0F2221F0 for ; Mon, 28 Dec 2020 03:48:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726292AbgL1Dsk (ORCPT ); Sun, 27 Dec 2020 22:48:40 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:39458 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbgL1Dsj (ORCPT ); Sun, 27 Dec 2020 22:48:39 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=chenshiyan@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UJwcEqn_1609127268; Received: from localhost(mailfrom:chenshiyan@linux.alibaba.com fp:SMTPD_---0UJwcEqn_1609127268) by smtp.aliyun-inc.com(127.0.0.1); Mon, 28 Dec 2020 11:47:57 +0800 From: chenshiyan To: fweisbec@gmail.com, tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V1] nohz: exit nohz idle before invoking softirq Date: Mon, 28 Dec 2020 11:47:48 +0800 Message-Id: <1609127268-40179-1-git-send-email-chenshiyan@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "shiyan.csy" exit nohz idle before invoking softirq, or it maymiss some ticks during softirq. Signed-off-by: Shiyan Chen --- kernel/softirq.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 9d71046..59bd6fe 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -404,6 +404,10 @@ static inline void tick_irq_exit(void) if (!in_irq()) tick_nohz_irq_exit(); } + + /* need to exit nohz idle if there's a softirq */ + if (in_serving_softirq() || local_softirq_pending()) + tick_nohz_idle_exit(); #endif } @@ -416,10 +420,11 @@ static inline void __irq_exit_rcu(void) #endif account_hardirq_exit(current); preempt_count_sub(HARDIRQ_OFFSET); - if (!in_interrupt() && local_softirq_pending()) - invoke_softirq(); + /* must call before invoke_softirq */ tick_irq_exit(); + if (!in_interrupt() && local_softirq_pending()) + invoke_softirq(); } /** -- 1.8.3.1