From: Yejune Deng <yejune.deng@gmail.com>
To: tglx@linutronix.de, maz@kernel.org
Cc: linux-kernel@vger.kernel.org, yejune.deng@gmail.com
Subject: [PATCH] irqchip/gic: add WARN_ON() to facilitate backtracking
Date: Tue, 29 Dec 2020 15:15:14 +0800 [thread overview]
Message-ID: <1609226114-32933-1-git-send-email-yejune.deng@gmail.com> (raw)
There is two function gic_of_init() and gic_of_init_child() called
gic_of_setup(),so add WARN_ON() to facilitate backtracking.
Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
---
drivers/irqchip/irq-gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index b1d9c22..7c11705 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -1380,7 +1380,7 @@ static bool gic_check_eoimode(struct device_node *node, void __iomem **base)
static int gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
{
- if (!gic || !node)
+ if (WARN_ON(!gic || !node))
return -EINVAL;
gic->raw_dist_base = of_iomap(node, 0);
--
1.9.1
next reply other threads:[~2020-12-29 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 7:15 Yejune Deng [this message]
2020-12-29 9:27 ` Marc Zyngier
2020-12-30 2:16 ` Yejune Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609226114-32933-1-git-send-email-yejune.deng@gmail.com \
--to=yejune.deng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®