From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753459AbdEJJCp (ORCPT ); Wed, 10 May 2017 05:02:45 -0400 Received: from mail-qt0-f176.google.com ([209.85.216.176]:35401 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752879AbdEJJCj (ORCPT ); Wed, 10 May 2017 05:02:39 -0400 Subject: Re: [PATCH v1] ata: sata_rcar: Handle return value of clk_prepare_enable To: Arvind Yadav , tj@kernel.org References: <1494325828-2725-1-git-send-email-arvind.yadav.cs@gmail.com> Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <16092444-34a3-bfcb-81df-5ecd63b6ffcb@cogentembedded.com> Date: Wed, 10 May 2017 12:02:37 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1494325828-2725-1-git-send-email-arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 5/9/2017 1:30 PM, Arvind Yadav wrote: > Here, Clock enable can failed. So adding an error check for Maybe "here enabling the clock can fail"? > clk_prepare_enable. > > Signed-off-by: Arvind Yadav Other than that: Acked-by: Sergei Shtylyov MBR, Sergei