From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37935C433E9 for ; Tue, 5 Jan 2021 22:08:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11BA2207B2 for ; Tue, 5 Jan 2021 22:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731638AbhAEWHz (ORCPT ); Tue, 5 Jan 2021 17:07:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:40230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729419AbhAEWHy (ORCPT ); Tue, 5 Jan 2021 17:07:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6515622EBE; Tue, 5 Jan 2021 22:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609884434; bh=6X9xh0B9e7jk8zQM37gLnc6Rfvt46/YI3ULCrl4E+0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ExbI2M6Ui3QyfRBhdrUi7GpiKAJoN6lx5R4MfJLgOWjxo94nPJ2V6ghl3wUF/luK7 Y0Q6HsQvwtYkanU46yCVavoHUnH5sOBwbPdiVrKV2KqLeq+jPejkwETiOqTJFFYUGR n77h+H235XHE9447prM8u7AkJflwIH/tp1Xvr/lhDRUjb8WI1y1kqU0gb0DUOWmmLp otXxR6PDgOlhl3n7yom/QPeXzid6FSzwyZKoajluUI1Zvm6uyrY5TZPPb7nKIREldm NHuVs4IhlmtOgs/wOgCntK7Gr/o9Z9uE/NSJvYaX07Wn0a/KHW3hHCyqmhxZYM4VAu PNsHZdQiXlrVg== From: Will Deacon To: Johnathan Smithinovic , mingo@redhat.com, David Woodhouse , tglx@linutronix.de, bp@alien8.de Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , x86@kernel.org, linux-kernel@vger.kernel.org, iommu Subject: Re: [PATCH] iommu/amd: Stop irq_remapping_select() matching when remapping is disabled Date: Tue, 5 Jan 2021 22:07:02 +0000 Message-Id: <160987465284.30865.16684216909917986687.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <04bbe8bca87f81a3cfa93ec4299e53f47e00e5b3.camel@infradead.org> References: <04bbe8bca87f81a3cfa93ec4299e53f47e00e5b3.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 05 Jan 2021 01:36:13 +0000, David Woodhouse wrote: > The AMD IOMMU initialisation registers the IRQ remapping domain for > each IOMMU before doing the final sanity check that every I/OAPIC is > covered. > > This means that the AMD irq_remapping_select() function gets invoked > even when IRQ remapping has been disabled, eventually leading to a NULL > pointer dereference in alloc_irq_table(). > > [...] Applied to arm64 (for-next/iommu/fixes), thanks! [1/1] iommu/amd: Stop irq_remapping_select() matching when remapping is disabled https://git.kernel.org/arm64/c/b34f10c2dc59 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev