From: Yongqiang Niu <yongqiang.niu@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
<dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Yongqiang Niu <yongqiang.niu@mediatek.com>
Subject: [PATCH v9, 08/11] drm/mediatek: add has_dither private data for gamma
Date: Thu, 7 Jan 2021 11:11:18 +0800 [thread overview]
Message-ID: <1609989081-29353-9-git-send-email-yongqiang.niu@mediatek.com> (raw)
In-Reply-To: <1609989081-29353-1-git-send-email-yongqiang.niu@mediatek.com>
not all SoC has dither function in gamma module
dd private data to control this function setting
Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
index 8501821..4eab82a 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
@@ -24,7 +24,7 @@
#define LUT_10BIT_MASK 0x03ff
struct mtk_disp_gamma_data {
- u32 reserved;
+ bool has_dither;
};
/**
@@ -72,7 +72,8 @@ static void mtk_gamma_config(struct mtk_ddp_comp *comp, unsigned int w,
mtk_ddp_write(cmdq_pkt, h << 16 | w, comp, DISP_GAMMA_SIZE);
- mtk_dither_set(comp, bpc, DISP_GAMMA_CFG, cmdq_pkt);
+ if (gamma->data && gamma->data->has_dither)
+ mtk_dither_set(comp, bpc, DISP_GAMMA_CFG, cmdq_pkt);
}
static void mtk_gamma_start(struct mtk_ddp_comp *comp)
@@ -168,8 +169,13 @@ static int mtk_disp_gamma_remove(struct platform_device *pdev)
return 0;
}
+static const struct mtk_disp_gamma_data mt8173_gamma_driver_data = {
+ .has_dither = true,
+};
+
static const struct of_device_id mtk_disp_gamma_driver_dt_match[] = {
- { .compatible = "mediatek,mt8173-disp-gamma"},
+ { .compatible = "mediatek,mt8173-disp-gamma",
+ .data = &mt8173_gamma_driver_data},
{},
};
MODULE_DEVICE_TABLE(of, mtk_disp_gamma_driver_dt_match);
--
1.8.1.1.dirty
next prev parent reply other threads:[~2021-01-07 3:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 3:11 [PATCH v9, 00/11] drm/mediatek: add support for mediatek SOC MT8183 Yongqiang Niu
2021-01-07 3:11 ` [PATCH v9, 01/11] dt-bindings: mediatek: add rdma-fifo-size description for mt8183 display Yongqiang Niu
2021-01-07 9:54 ` Chun-Kuang Hu
2021-01-12 14:49 ` Rob Herring
2021-01-13 15:28 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 02/11] dt-bindings: mediatek: add " Yongqiang Niu
2021-01-07 10:17 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 03/11] arm64: dts: mt8183: rename rdma fifo size Yongqiang Niu
2021-01-07 9:58 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 04/11] arm64: dts: mt8183: refine gamma compatible name Yongqiang Niu
2021-01-07 3:11 ` [PATCH v9, 05/11] drm/mediatek: add fifo_size into rdma private data Yongqiang Niu
2021-01-07 10:05 ` Chun-Kuang Hu
2021-01-14 23:27 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 06/11] drm/mediatek: add RDMA fifo size error handle Yongqiang Niu
2021-01-07 3:11 ` [PATCH v9, 07/11] drm/mediatek: separate gamma module Yongqiang Niu
2021-01-07 10:25 ` Chun-Kuang Hu
2021-01-07 3:11 ` Yongqiang Niu [this message]
2021-01-07 10:29 ` [PATCH v9, 08/11] drm/mediatek: add has_dither private data for gamma Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 09/11] drm/mediatek: enable dither function Yongqiang Niu
2021-01-07 3:11 ` [PATCH v9, 10/11] drm/mediatek: add DDP support for MT8183 Yongqiang Niu
2021-01-07 12:08 ` Chun-Kuang Hu
2021-01-07 3:11 ` [PATCH v9, 11/11] This patch add support for mediatek SOC MT8183 Yongqiang Niu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609989081-29353-9-git-send-email-yongqiang.niu@mediatek.com \
--to=yongqiang.niu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®