From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B2EE3612C5 for ; Fri, 19 Dec 2025 16:47:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766162840; cv=none; b=PnJNsuTAc+MFr69b9PW/VBPRnQwdHzRh5xIlngJKHDo4v9cb59lyhFPSYcazXn50+pWomYiQcVgSl/R4ioXQBB1kcMDxf5N0Bq1jWF3+Sg4Otz/OCYCrx/pb6MZ4tDZ0P0P/3KIEIvO7QmwyCo1F6hul+1JFHV1YdrZphkfPpOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766162840; c=relaxed/simple; bh=jhRk3Ipk7e68GLhh5OnW32OvRpsBRz+3p+xrVBoz+Rs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qTD7IY+XZgGnTlC6B4iWegnB0LHN7xgHqn9rC+yrB1Bc7iajCmz48HNEdQTxj5bVf5mqF1MgVYrNA9ejZaV7yOvdrrw5QvkCurMxLJfqifGLwDsA8qwji516NpGyRkHXj//6lT99Y8nky2jXVl2wFvh6VjrfCftP9VEjMRnDC44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z9ADlUcu; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z9ADlUcu" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-bde0f62468cso2074542a12.2 for ; Fri, 19 Dec 2025 08:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766162836; x=1766767636; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=IOervZ2wireH/C15tXnZc6MfLwrTuJtgTvxZVl4SpmM=; b=Z9ADlUcu4NlJ7tzfe8L99H7dh/nsXQ6MGu5NgJ3zKTqSySfm4bHnoGYcss/X6sd/cU dR/MU2fvuG6vwwsdTT4ZhZk+ZK7V3OcmD5vEb6P+70HS13PfPD3gIK+3KXNv/2gb11xM iyNIyf6blDk60Dz37LU7LJxjRnjPXI8vtvY7ELwj0NL9LSMTXIPw0xzXI0PQzGijeTqN 9D56FObrIiUVnfpKL098JtIL4smXhG2vKlWpTl62WQR2IJbTeZd8CcIXfKt7TfBCMBxa xQS0OWkHQL7Uw8SxCpcd+ggDQBRRDLJkjEnat81/OAvlChP41ExTGJB0DM2mAc+7rvOR zSDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766162836; x=1766767636; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IOervZ2wireH/C15tXnZc6MfLwrTuJtgTvxZVl4SpmM=; b=wnLAdZt87vO/U1Qe2/HLqVFf6BvKI5Nq+zaoXGzlCITBTTjgl3YEAACsxPWR4dZ/2Z Hc2Xl+haI6GlVP5LHg6it6hv/xAOqrFZQfKK7OgX/gdt47W7y/cCK16cQK25CH4Wdo2c +sFTBl3TNVC/CKa3gVJZ9OLUc9Lzb/jAf26uNQvHgk5JkuEDkPsr4vqIFtvN8Ft7hZWL 1r/PLA9IPUdKUpjyJWuAQMlIgz+4/iODwPMdxM6XQu0Um/lT2ztGgEnqk0azgT17W1Zt OMcZMwhGpZ1TG7iydGw+T7xt4zxSVITlYoylu4hAPh6vqElBtDG+FZ63CQrJ4hGg9jhy JmMQ== X-Forwarded-Encrypted: i=1; AJvYcCWT5LSZoRuD0kuK9iK+X6k8Wr5j8HNabtSLXRe83SoE3c5AWdAMM51oF6LoYBnJk0VnAcwnMHlXVX2nKfI=@vger.kernel.org X-Gm-Message-State: AOJu0YySidIEJ2U3uDwGMg23kFpyGFM8oRDij+qdyM9R2bCdkuHv8qWZ m4XNF/JGKBNbStdSika3OkrYGO09T1u2+sJYip3FZAj8MzEoos5j5bXXKuoxCQ== X-Gm-Gg: AY/fxX6+FuVHsxsU1wfOg3QgYHjV3HvgKxe30XFzEQuhSvaG4nmA5RbecIpBon3FFzh naJ/tbTnHmMkYsJ6N13wcpOACGHsV+FRBHhC2aHQkggX08LH2pwdaFDQR5n2PKq1kDt30p039QG KOo6AyYNXbK8s5BHhKBlFIcsyp3XEyriC8XxOBzxEzDIS0Kl1XbBXgi5q3kCA19v32zzakWmTOU Y9MoX7JVph2ksxw1o74/E2+B2NW1N0galUM2o9ToZ9YATCGLjjuVGtXzM8xNY3xmCrz35FQM1hZ /aOJYNO+BV0gPu1uFw0WUQZjsF70CnfsTBIaV+pikwfSB3VATmOaSlPYnzY59f5t6bYWhaMBDQW 4qbP/Tia0COMtSsHDluS5qSmAMQGWdEL2oX0x8PwZ+ZyK4tTFUbB0v9DQCVQbcWcT1m3qO9AuUC oKKU35ZokEndELFC4e/+fNRuHK X-Google-Smtp-Source: AGHT+IFNCTi0/O17x/JCP+ojFIqzO60a/e+LUTFZOFQTe8hd6b0gSlm1Ew46MEctgTXA5AbFxuiOUA== X-Received: by 2002:a05:693c:6016:b0:2ae:5a73:23d6 with SMTP id 5a478bee46e88-2b05ec17300mr3031836eec.19.1766162835465; Fri, 19 Dec 2025 08:47:15 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b05fcfc1b7sm6769004eec.0.2025.12.19.08.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 08:47:15 -0800 (PST) Sender: Guenter Roeck Date: Fri, 19 Dec 2025 08:47:14 -0800 From: Guenter Roeck To: Kari Argillander Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] hwmon: Use sysfs_emit in show function callsbacks Message-ID: <160f3844-e142-47ab-a0b5-5e9512aac568@roeck-us.net> References: <20251219-hwmon-fixes-v1-0-21b29097ea3b@gmail.com> <20251219-hwmon-fixes-v1-2-21b29097ea3b@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251219-hwmon-fixes-v1-2-21b29097ea3b@gmail.com> On Fri, Dec 19, 2025 at 05:48:15PM +0200, Kari Argillander wrote: > Use sysfs_emit() over sprintf() to prevent potential overflows. In > hwmon_attr_show() that is totally impossible but looking other places > many still use sysfs_emit(). > > Also according Documentation/filesystems/sysfs.rst code should use > sysfs_emit(). > > Signed-off-by: Kari Argillander Applied. Thanks, Guenter > --- > drivers/hwmon/hwmon.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c > index 7a784d685d77..714caa6a36a3 100644 > --- a/drivers/hwmon/hwmon.c > +++ b/drivers/hwmon/hwmon.c > @@ -73,7 +73,7 @@ struct hwmon_thermal_data { > static ssize_t > name_show(struct device *dev, struct device_attribute *attr, char *buf) > { > - return sprintf(buf, "%s\n", to_hwmon_device(dev)->name); > + return sysfs_emit(buf, "%s\n", to_hwmon_device(dev)->name); > } > static DEVICE_ATTR_RO(name); > > @@ -446,7 +446,7 @@ static ssize_t hwmon_attr_show(struct device *dev, > trace_hwmon_attr_show(hattr->index + hwmon_attr_base(hattr->type), > hattr->name, val64); > > - return sprintf(buf, "%lld\n", val64); > + return sysfs_emit(buf, "%lld\n", val64); > } > > static ssize_t hwmon_attr_show_string(struct device *dev, > @@ -469,7 +469,7 @@ static ssize_t hwmon_attr_show_string(struct device *dev, > trace_hwmon_attr_show_string(hattr->index + hwmon_attr_base(type), > hattr->name, s); > > - return sprintf(buf, "%s\n", s); > + return sysfs_emit(buf, "%s\n", s); > } > > static ssize_t hwmon_attr_store(struct device *dev,