mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lars Melin <larsm17@gmail.com>
To: "Bolan Wang(Bolan)" <bolan.wang@fibocom.com>,
	"johan@kernel.org" <johan@kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
Date: Wed, 6 Mar 2024 13:39:54 +0700	[thread overview]
Message-ID: <160fdf7f-553a-40ed-8493-95a7d31a8b38@gmail.com> (raw)
In-Reply-To: <KL1PR02MB6283EBD2786A3B3E4E373F0389212@KL1PR02MB6283.apcprd02.prod.outlook.com>

On 2024-03-06 13:18, Bolan Wang(Bolan) wrote:
>> If the device with pid 0x01a1 only has an mbim interface as you have indicated then why do you add it to the option serial driver?
> 
> Hi Lars:
>    The pid 0x01a1 may include at, diag ports in different usb modes. Currently, only has the mbim interface.
> 
> thanks
> bolan

Hi Bolan,
so you already know that other versions of the card will have the pid 
0x01a1 and the serial interfaces will be of class ff but you don't
know what those interfaces will be used for?
You shall only add driver support for what you know today and not for 
something that might or might not be implemented in the future.

For the device with pid 0x0115 you have listed an adb interface and adb 
interfaces should not be in the option driver.

thanks
Lars



  reply	other threads:[~2024-03-06  6:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  6:18 Bolan Wang(Bolan)
2024-03-06  6:39 ` Lars Melin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-03-06  9:35 bolan wang
2024-03-06 10:05 ` Johan Hovold
2024-03-06  8:45 Bolan Wang(Bolan)
2024-03-06  8:20 bolan wang
2024-03-06  7:41 Bolan Wang(Bolan)
2024-03-06  8:29 ` Lars Melin
2024-03-06  2:13 bolan wang
2024-03-06  5:55 ` Lars Melin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160fdf7f-553a-40ed-8493-95a7d31a8b38@gmail.com \
    --to=larsm17@gmail.com \
    --cc=bolan.wang@fibocom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®