mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Greg KH <greg@kroah.com>, Miles Lane <miles.lane@attbi.com>,
	willy@debian.org,
	linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: Looks like your PCI patch broke the PPC build (and others)?
Date: Fri, 13 Jun 2003 08:31:13 +1000 (EST)	[thread overview]
Message-ID: <16104.65329.190055.862284@nanango.paulus.ozlabs.org> (raw)
In-Reply-To: <1055424925.604.39.camel@gaston>

Benjamin Herrenschmidt writes:

> Well... asm/pci-bridge.h includes linux/pci.h which includes asm/pci.h,
> so we have a circular include here...

True, but it seems that the multiple inclusion protection saves us. :)

> What I did in my tree is to move the definition of pci_controller
> from asm/pci-bridge.h to asm/pci.h. I'm now considering removing
> asm/pci-bridge.h, what do you think ?

We could do that.  It might be simpler to just take pci_domain_nr out
of line again though.

Paul.

      reply	other threads:[~2003-06-12 22:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-11 19:15 Miles Lane
2003-06-11 20:28 ` Greg KH
2003-06-12  7:10   ` Paul Mackerras
2003-06-12 13:35     ` Benjamin Herrenschmidt
2003-06-12 22:31       ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16104.65329.190055.862284@nanango.paulus.ozlabs.org \
    --to=paulus@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles.lane@attbi.com \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®