From: patchwork-bot+netdevbpf@kernel.org
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, trix@redhat.com,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix handling of an unsupported token type in rxrpc_read()
Date: Wed, 13 Jan 2021 18:50:08 +0000 [thread overview]
Message-ID: <161056380826.22635.6329144263801911858.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <161046503122.2445787.16714129930607546635.stgit@warthog.procyon.org.uk>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 12 Jan 2021 15:23:51 +0000 you wrote:
> Clang static analysis reports the following:
>
> net/rxrpc/key.c:657:11: warning: Assigned value is garbage or undefined
> toksize = toksizes[tok++];
> ^ ~~~~~~~~~~~~~~~
>
> rxrpc_read() contains two consecutive loops. The first loop calculates the
> token sizes and stores the results in toksizes[] and the second one uses
> the array. When there is an error in identifying the token in the first
> loop, the token is skipped, no change is made to the toksizes[] array.
> When the same error happens in the second loop, the token is not skipped.
> This will cause the toksizes[] array to be out of step and will overrun
> past the calculated sizes.
>
> [...]
Here is the summary with links:
- [net] rxrpc: Fix handling of an unsupported token type in rxrpc_read()
https://git.kernel.org/netdev/net/c/d52e419ac8b5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-01-13 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 15:23 David Howells
2021-01-13 18:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161056380826.22635.6329144263801911858.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®