From: David Mosberger <davidm@napali.hpl.hp.com>
To: neilb@cse.unsw.edu.au
Cc: nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org,
davidm@napali.hpl.hp.com
Subject: make NFS work with 64KB page-size
Date: Wed, 18 Jun 2003 15:56:31 -0700 [thread overview]
Message-ID: <16112.60959.588900.824473@napali.hpl.hp.com> (raw)
NFS currently bugs out on kernels with a page size of 64KB. The
reason is a mismatch between RPCSVC_MAXPAGES and a calculation in
svc_init_buffer(). I'm not entirely certain which calculation is the
right one, but if I understand the code correctly, RPCSVC_MAXPAGES is
right and svc_init_buffer() is wrong. The patch below fixes the
latter.
If the patch looks right, could you make sure it finds its way into
Linus' tree?
Thanks,
--david
===== net/sunrpc/svc.c 1.20 vs edited =====
--- 1.20/net/sunrpc/svc.c Fri Feb 7 12:25:20 2003
+++ edited/net/sunrpc/svc.c Wed Jun 18 15:02:19 2003
@@ -111,7 +111,7 @@
static int
svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
{
- int pages = 2 + (size+ PAGE_SIZE -1) / PAGE_SIZE;
+ int pages = 1 + (size+ PAGE_SIZE -1) / PAGE_SIZE;
int arghi;
rqstp->rq_argused = 0;
next reply other threads:[~2003-06-18 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-18 22:56 David Mosberger [this message]
2003-06-19 1:41 ` Neil Brown
2003-06-19 1:21 ` David Mosberger
2003-06-19 1:26 ` Mr. James W. Laferriere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16112.60959.588900.824473@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®