From: Kuldeep Singh <kuldeep.singh@nxp.com>
To: Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Li Yang <leoyang.li@nxp.com>,
Kuldeep Singh <kuldeep.singh@nxp.com>
Subject: [Patch v2 2/3] arm64: dtsi: ls1028a: Update flexcan properties
Date: Thu, 21 Jan 2021 16:27:38 +0530 [thread overview]
Message-ID: <1611226659-30129-3-git-send-email-kuldeep.singh@nxp.com> (raw)
In-Reply-To: <1611226659-30129-1-git-send-email-kuldeep.singh@nxp.com>
LS1028A supports two flexcan controllers similar to LX2160A.
There's already a compatible entry defined i.e "fsl,lx2160ar1-flexcan"
which can be further reused for LS1028A.
Please note, "fsl,ls1028ar1-flexcan" compatible entry doesn't exists and
can be safely removed.
LS1028A has a single peripheral clock (i.e platform clock) source
connected to both "ipg" and "per" and therefore, remove "sysclk" as
clock source from device-tree.
Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
---
Hi Shawn,
I would like to mention the motivation behind compatible string change.
There's no ls1028a compatible entry i.e " fsl,ls1028ar1-flexcan" in flexcan
driver. See below.
https://elixir.bootlin.com/linux/latest/source/drivers/net/can/flexcan.c#L1913
And the documentation says that ls1028a entry should be followed by lx2160a.
https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml#L42
Since ls1028a entry is not present, anyway lx2160a entry will be eventually used.
Please let me know your views.
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index e00acad..d28bd52 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -408,21 +408,25 @@
};
can0: can@2180000 {
- compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan";
+ compatible = "fsl,lx2160ar1-flexcan";
reg = <0x0 0x2180000 0x0 0x10000>;
interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&sysclk>, <&clockgen QORIQ_CLK_PLATFORM_PLL
- QORIQ_CLK_PLL_DIV(2)>;
+ clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
+ QORIQ_CLK_PLL_DIV(2)>,
+ <&clockgen QORIQ_CLK_PLATFORM_PLL
+ QORIQ_CLK_PLL_DIV(2)>;
clock-names = "ipg", "per";
status = "disabled";
};
can1: can@2190000 {
- compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan";
+ compatible = "fsl,lx2160ar1-flexcan";
reg = <0x0 0x2190000 0x0 0x10000>;
interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&sysclk>, <&clockgen QORIQ_CLK_PLATFORM_PLL
- QORIQ_CLK_PLL_DIV(2)>;
+ clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
+ QORIQ_CLK_PLL_DIV(2)>,
+ <&clockgen QORIQ_CLK_PLATFORM_PLL
+ QORIQ_CLK_PLL_DIV(2)>;
clock-names = "ipg", "per";
status = "disabled";
};
--
2.7.4
next prev parent reply other threads:[~2021-01-21 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 10:57 [Patch v2 0/3] Enable flexcan support in LS1028A/LX2160A Kuldeep Singh
2021-01-21 10:57 ` [Patch v2 1/3] arm64: dts: lx2160a: Add flexcan support Kuldeep Singh
2021-01-21 10:57 ` Kuldeep Singh [this message]
2021-01-21 10:57 ` [Patch v2 3/3] arm64: dts: ls1028a: Enable flexcan support for LS1028A-RDB/QDS Kuldeep Singh
2021-01-30 13:24 ` [Patch v2 0/3] Enable flexcan support in LS1028A/LX2160A Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1611226659-30129-3-git-send-email-kuldeep.singh@nxp.com \
--to=kuldeep.singh@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®