From: mtk15103 <hailong.fan@mediatek.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Sean Wang <sean.wang@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<youlin.pei@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>,
<srv_heupstream@mediatek.com>, <chentsung@chromium.org>,
<gtk_pangao@mediatek.com>, Hanks Chen <hanks.chen@mediatek.com>,
<yong.wu@mediatek.com>
Subject: Re: [PATCH V3] pinctrl: mediatek: Fix trigger type setting follow for unexpected interrupt
Date: Tue, 26 Jan 2021 09:22:35 +0800 [thread overview]
Message-ID: <1611624155.1248.14.camel@mhfsdcap03> (raw)
In-Reply-To: <CACRpkdadvp9t5xdpK+=35jwfbrR0AXM0bRSWBfWH9jJFBbEyeA@mail.gmail.com>
On Mon, 2021-01-25 at 14:11 +0100, Linus Walleij wrote:
> On Mon, Jan 25, 2021 at 5:18 AM Hailong Fan <hailong.fan@mediatek.com> wrote:
>
> > When flipping the polarity will be generated interrupt under certain
> > circumstances, but GPIO external signal has not changed.
> > Then, mask the interrupt before polarity setting, and clear the
> > unexpected interrupt after trigger type setting completed.
> >
> > Remove mtk_eint_flip_edge: because mtk_eint_unmask already calls it.
> >
> > Signed-off-by: Hailong Fan <hailong.fan@mediatek.com>
> > Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
>
> Took out v2 and applied this v3 instead.
> (No idea what the difference is, you don't say.)
V3 only add commit message "Remove mtk_eint_flip_edge: because mtk_eint_unmask already calls it."
Compared to V2, the patch has not changed.
Thanks.
> Yours,
> Linus Walleij
prev parent reply other threads:[~2021-01-26 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 4:17 Hailong Fan
2021-01-25 13:11 ` Linus Walleij
2021-01-26 1:22 ` mtk15103 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1611624155.1248.14.camel@mhfsdcap03 \
--to=hailong.fan@mediatek.com \
--cc=chentsung@chromium.org \
--cc=drinkcat@chromium.org \
--cc=gtk_pangao@mediatek.com \
--cc=hanks.chen@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®