From: Will Deacon <will@kernel.org>
To: robin.murphy@arm.com, bjorn.andersson@linaro.org,
"Isaac J. Manjarres" <isaacm@codeaurora.org>,
joro@8bytes.org
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] iommu/arm-smmu-qcom: Fix mask extraction for bootloader programmed SMRs
Date: Tue, 26 Jan 2021 22:35:41 +0000 [thread overview]
Message-ID: <161167109569.3787430.13165422969483638185.b4-ty@kernel.org> (raw)
In-Reply-To: <1611611545-19055-1-git-send-email-isaacm@codeaurora.org>
On Mon, 25 Jan 2021 13:52:25 -0800, Isaac J. Manjarres wrote:
> When extracting the mask for a SMR that was programmed by the
> bootloader, the SMR's valid bit is also extracted and is treated
> as part of the mask, which is not correct. Consider the scenario
> where an SMMU master whose context is determined by a bootloader
> programmed SMR is removed (omitting parts of device/driver core):
>
> ->iommu_release_device()
> -> arm_smmu_release_device()
> -> arm_smmu_master_free_smes()
> -> arm_smmu_free_sme() /* Assume that the SME is now free */
> -> arm_smmu_write_sme()
> -> arm_smmu_write_smr() /* Construct SMR value using mask and SID */
>
> [...]
Applied to will (for-joerg/arm-smmu/updates), thanks!
[1/1] iommu/arm-smmu-qcom: Fix mask extraction for bootloader programmed SMRs
https://git.kernel.org/will/c/dead723e6f04
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2021-01-27 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 21:52 Isaac J. Manjarres
2021-01-26 10:34 ` Robin Murphy
2021-01-26 22:35 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161167109569.3787430.13165422969483638185.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®