From: Babu Moger <babu.moger@amd.com>
To: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc: fenghua.yu@intel.com, tony.luck@intel.com, wanpengli@tencent.com,
kvm@vger.kernel.org, thomas.lendacky@amd.com,
peterz@infradead.org, seanjc@google.com, joro@8bytes.org,
x86@kernel.org, kyung.min.park@intel.com,
linux-kernel@vger.kernel.org, krish.sadhukhan@oracle.com,
hpa@zytor.com, mgross@linux.intel.com, vkuznets@redhat.com,
kim.phillips@amd.com, wei.huang2@amd.com, jmattson@google.com
Subject: [PATCH v4 0/2] x86: Add the feature Virtual SPEC_CTRL
Date: Thu, 28 Jan 2021 18:43:16 -0600 [thread overview]
Message-ID: <161188083424.28787.9510741752032213167.stgit@bmoger-ubuntu> (raw)
Newer AMD processors have a feature to virtualize the use of the
SPEC_CTRL MSR on the guest. The series adds the feature support
and enables the feature on SVM.
---
v4:
1. Taken care of comments from Sean Christopherson.
a. Updated svm_set_msr/svm_get_msr to read/write the spec_ctrl value
directly from save spec_ctrl.
b. Disabled the msr_interception in init_vmcb when V_SPEC_CTRL is
present.
c. Added the save restore for nested vm. Also tested to make sure
the nested SPEC_CTRL settings properly saved and restored between
L2 and L1 guests.
2. Added the kvm-unit-tests to verify that. Sent those patches separately.
v3:
1. Taken care of recent changes in vmcb_save_area. Needed to adjust the save
area spec_ctrl definition.
2. Taken care of few comments from Tom.
a. Initialised the save area spec_ctrl in case of SEV-ES.
b. Removed the changes in svm_get_msr/svm_set_msr.
c. Reverted the changes to disable the msr interception to avoid compatibility
issue.
3. Updated the patch #1 with Acked-by from Boris.
v2:
NOTE: This is not final yet. Sending out the patches to make
sure I captured all the comments correctly.
1. Most of the changes are related to Jim and Sean's feedback.
2. Improved the description of patch #2.
3. Updated the vmcb save area's guest spec_ctrl value(offset 0x2E0)
properly. Initialized during init_vmcb and svm_set_msr and
returned the value from save area for svm_get_msr.
4. As Jim commented, transferred the value into the VMCB prior
to VMRUN and out of the VMCB after #VMEXIT.
5. Added kvm-unit-test to detect the SPEC CTRL feature.
https://lore.kernel.org/kvm/160865324865.19910.5159218511905134908.stgit@bmoger-ubuntu/
6. Sean mantioned of renaming MSR_AMD64_VIRT_SPEC_CTRL. But, it might
create even more confusion, so dropped the idea for now.
v3: https://lore.kernel.org/kvm/161073115461.13848.18035972823733547803.stgit@bmoger-ubuntu/
v2: https://lore.kernel.org/kvm/160867624053.3471.7106539070175910424.stgit@bmoger-ubuntu/
v1: https://lore.kernel.org/kvm/160738054169.28590.5171339079028237631.stgit@bmoger-ubuntu/
Babu Moger (2):
x86/cpufeatures: Add the Virtual SPEC_CTRL feature
KVM: SVM: Add support for Virtual SPEC_CTRL
arch/x86/include/asm/cpufeatures.h | 1 +
arch/x86/include/asm/svm.h | 4 +++-
arch/x86/kvm/svm/nested.c | 2 ++
arch/x86/kvm/svm/svm.c | 27 ++++++++++++++++++++++-----
4 files changed, 28 insertions(+), 6 deletions(-)
--
next reply other threads:[~2021-01-29 0:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 0:43 Babu Moger [this message]
2021-01-29 0:43 ` [PATCH v4 1/2] x86/cpufeatures: Add the Virtual SPEC_CTRL feature Babu Moger
2021-01-29 0:43 ` [PATCH v4 2/2] KVM: SVM: Add support for Virtual SPEC_CTRL Babu Moger
2021-02-11 8:56 ` Paolo Bonzini
2021-02-11 22:42 ` Babu Moger
2022-06-04 3:11 ` Jim Mattson
2022-06-13 15:09 ` Tom Lendacky
2022-06-13 19:23 ` Jim Mattson
2022-06-13 20:16 ` Tom Lendacky
2022-06-13 20:28 ` Jim Mattson
2021-02-10 23:40 ` [PATCH v4 0/2] x86: Add the feature " Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161188083424.28787.9510741752032213167.stgit@bmoger-ubuntu \
--to=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kim.phillips@amd.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=kyung.min.park@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=wei.huang2@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®