From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B32B4C433E0 for ; Tue, 9 Feb 2021 07:50:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 821AA64EAA for ; Tue, 9 Feb 2021 07:50:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229770AbhBIHuj (ORCPT ); Tue, 9 Feb 2021 02:50:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbhBIHuc (ORCPT ); Tue, 9 Feb 2021 02:50:32 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34AF9C061786 for ; Mon, 8 Feb 2021 23:49:52 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id t2so1160915pjq.2 for ; Mon, 08 Feb 2021 23:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=6b+/hQj0it6g8F6bTJeurencxJxcBJHtadbYzgx+xnE=; b=by/+gUaQ+eg/pn6zkZeCenRotSr/+0zlz89VffWJuNaVZm9c/xRuRS2Sxl5IjDXM8i vpua9sxlbofuvH3dFKL6iM/UUBMcANrZJaMwOz1oCFSu5vHhqQgsjxeAJ4snRiWGptgh 5a748XI9aPlOcq78XjVCJfUgnt6jpXa+VX4FPDM3BB3L4gaJLsTVvqn1ac5EcakM2khs vLMt9ulYhR0LJi555fh9e0QnZLP0ycG8nU724dtDMeyb3PpHoTc/cLjySMnW1K7eR6LS ZhMbKAOfVrNOKWL0P218ALx78Qk3v6ovk3i75WkRmIpCr1cFeuGXTsSEAvzRw4K+C6GO 18mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=6b+/hQj0it6g8F6bTJeurencxJxcBJHtadbYzgx+xnE=; b=kJKPspXBr5LY9hwcvm8123CdReqlC+BGLZ3ByutSbt7jM28v67nJULRiqI4/dVOsJJ yat6M6mNE5C70GWJvoQtPoacwARssELPiZmIN6unsmUpUUaV9uCezM8HT3kwYsTV7PO0 RUvYGey+wxmm9hFai9yHJ1XiXUcyOcbwOgIbc7q7tky5AtBLblcUumQMS954CDBF+vDJ 9gJbYr72bKuGz9C3Ty0ylV+gKetUIRFVfUZNvX4G9qEJ5Mgll5N1aSEUeqf/AxMlIGJJ FUgpsn1ywSUSUmjjAgoSWKV3qsqQ7eyLRx2/E3T63ZxW2D1gbjEe3nZaOsgVGwfkyJy1 E+Ow== X-Gm-Message-State: AOAM531UCSFvwzeR6jhDuM0ULepCR2preqeamxK6P452f5boTt+od5KR u5p7I2LB5t9dTHLZ3sgR448= X-Google-Smtp-Source: ABdhPJz2eu+sBmByunrt7c4+X8GZAthouJ6qZ0B2xe6a/IDMiOE324Bn35/zJ3hc09l/KehHSpSdlw== X-Received: by 2002:a17:902:8306:b029:e2:d561:9ba9 with SMTP id bd6-20020a1709028306b02900e2d5619ba9mr8944276plb.5.1612856991840; Mon, 08 Feb 2021 23:49:51 -0800 (PST) Received: from localhost ([1.132.145.225]) by smtp.gmail.com with ESMTPSA id y26sm21385293pgk.42.2021.02.08.23.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 23:49:51 -0800 (PST) Date: Tue, 09 Feb 2021 17:49:45 +1000 From: Nicholas Piggin Subject: Re: [PATCH v5 05/22] powerpc/irq: Add helper to set regs->softe To: Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , msuchanek@suse.de, Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <5f37d1177a751fdbca79df461d283850ca3a34a2.1612796617.git.christophe.leroy@csgroup.eu> <1612832745.vhjk6358hf.astroid@bobo.none> <5987787e-ee80-ed0e-0c34-9884f6aad3c5@csgroup.eu> In-Reply-To: <5987787e-ee80-ed0e-0c34-9884f6aad3c5@csgroup.eu> MIME-Version: 1.0 Message-Id: <1612856863.0x6ebz3hce.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Excerpts from Christophe Leroy's message of February 9, 2021 4:18 pm: >=20 >=20 > Le 09/02/2021 =C3=A0 02:11, Nicholas Piggin a =C3=A9crit=C2=A0: >> Excerpts from Christophe Leroy's message of February 9, 2021 1:10 am: >>> regs->softe doesn't exist on PPC32. >>> >>> Add irq_soft_mask_regs_set_state() helper to set regs->softe. >>> This helper will void on PPC32. >>> >>> Signed-off-by: Christophe Leroy >>> --- >>=20 >> You could do the same with the kuap_ functions to change some ifdefs >> to IS_ENABLED. >>=20 >> That's just my preference but if you prefer this way I guess that's >> okay. >>=20 >=20 >=20 > That's also my preference on the long term. >=20 > Here it is ephemeral, I have a follow up series implementing interrupt ex= it/entry in C and getting=20 > rid of all the assembly kuap hence getting rid of those ifdefs. I thought it might have been because you hate ifdef more tha most :) =20 > The issue I see when using IS_ENABLED() is that you have to indent to the= right, then you interfere=20 > with the file history and 'git blame' Valid point if it's just going to indent back the other way in your next=20 series. > Thanks for reviewing my series and looking forward to your feedback on my= series on the interrupt=20 > entry/exit that I will likely release later today. Cool, I'm eager to see them. Thanks, Nick