From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755368AbcLQIYW convert rfc822-to-8bit (ORCPT ); Sat, 17 Dec 2016 03:24:22 -0500 Received: from mx4-phx2.redhat.com ([209.132.183.25]:48461 "EHLO mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752270AbcLQIYU (ORCPT ); Sat, 17 Dec 2016 03:24:20 -0500 Date: Sat, 17 Dec 2016 03:24:18 -0500 (EST) From: Paolo Bonzini To: Pan Xinhui Cc: Linus Torvalds , Linux Kernel Mailing List , Radim =?utf-8?B?S3LEjW3DocWZ?= , KVM list Message-ID: <1613156865.4447183.1481963058209.JavaMail.zimbra@redhat.com> In-Reply-To: <0df8ceac-deeb-d3c2-630c-30f84d363873@linux.vnet.ibm.com> References: <1481907450-11741-1-git-send-email-pbonzini@redhat.com> <0df8ceac-deeb-d3c2-630c-30f84d363873@linux.vnet.ibm.com> Subject: Re: [GIT PULL] KVM fixes for 4.10 merge window MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.4.164.1, 10.5.100.50] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF50 (Linux)/8.0.6_GA_5922) Thread-Topic: KVM fixes for 4.10 merge window Thread-Index: Qht+dh8yFReTkDLN4Dbl8206wJhBOQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > From: "Pan Xinhui" > To: "Linus Torvalds" , "Paolo Bonzini" > Cc: "Linux Kernel Mailing List" , "Radim Krčmář" , "KVM list" > > Sent: Saturday, December 17, 2016 4:09:16 AM > Subject: Re: [GIT PULL] KVM fixes for 4.10 merge window > > > > 在 2016/12/17 03:42, Linus Torvalds 写道: > > On Fri, Dec 16, 2016 at 8:57 AM, Paolo Bonzini wrote: > >> > >> git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus > > > > This piece-of-shit branch has obviously never been even compile-tested: > > > > arch/x86/kernel/kvm.c: In function ‘__kvm_vcpu_is_preempted’: > > arch/x86/kernel/kvm.c:596:14: error: ‘struct kvm_steal_time’ has no > > member named ‘preempted’ > > > hi, Linus > oh, my bad also. I introduce this struct member and use it in same patch. > Better to separate tem into two patches. I make one fix patch below. sorry > again. Hi Xinhui, don't worry it's purely my fault. :) > I have known where is th problem, I think if we can set this ->preempted > later after preempted_enable() > or just introduce something like write_guest_nosleep (per cpu memory section > in guest, so there is no page_fault or any other cannot sleep problems)? Yes there is already kvm_read_guest_inatomic, we can add an equivalent one for writes. It will be for 4.11 anyway, so there's time. Paolo