From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202AbdHJGba (ORCPT ); Thu, 10 Aug 2017 02:31:30 -0400 Received: from mail-by2nam03on0050.outbound.protection.outlook.com ([104.47.42.50]:62080 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751771AbdHJGb0 (ORCPT ); Thu, 10 Aug 2017 02:31:26 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; perches.com; dkim=none (message not signed) header.d=none;perches.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH] iio: adc: Fix coding style violations To: Joe Perches , Michal Simek , , CC: Sai Krishna Potthuri , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Cameron , References: <1502207564.2219.35.camel@perches.com> From: Michal Simek Message-ID: <1613ba5c-9441-4aa8-6cdf-28af790eeaa6@xilinx.com> Date: Thu, 10 Aug 2017 08:31:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502207564.2219.35.camel@perches.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23246.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39400400002)(39410400002)(39860400002)(39850400002)(39450400003)(2980300002)(438002)(377424004)(189002)(24454002)(199003)(8666007)(6666003)(54906002)(2950100002)(50986999)(76176999)(54356999)(36386004)(229853002)(53546010)(2906002)(63266004)(86362001)(478600001)(31686004)(47776003)(31696002)(305945005)(64126003)(356003)(4001350100001)(65806001)(65956001)(4326008)(9786002)(626005)(77096006)(65826007)(8676002)(6246003)(2201001)(50466002)(106466001)(38730400002)(8936002)(5660300001)(81166006)(81156014)(189998001)(33646002)(230700001)(23676002)(36756003)(83506001)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR02MB3388;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2NAM02FT003;1:2kyr+a5rmc3IiCw+1hjc2RdP40ZPkUI78n5hCefur5RACG1Uu4v81B0EAnLNEN9Rw+5vqknXB2zCKY73PDZIrndfSLt6ptx/XXBjYr8uNBrgMFtWF3gZX/7LNyETdUnQkbQiL1fUJ5D8wYPVxdIEmxBtSQaX0R7CGXnlpDyRwGnqPWcq0OLCmrL10eVfYZpOvaT4h53IYXc3tFl3JFaXpdK0Q7yl2Ev9LF3VeLWyb9OLaVDw+HJoJXZFRwQi1g0Tt+t8r+WeApzYW95EHSqcO/kJVr8Jizt4sZlK8nHll+l1nFIbVbgcGruBK3JflwF3wqy9lG917wFmt0sjzYFqRouZJ31wT8zRumF5BCrpvOOJNx2aOq+TIzAmL8DSdz2n5NlPY3HI+QkwQB5YUiNEBf1Kok3CEYGQ7VTSSMjNNiQWJ3MsAG3lyJqMMQH2MOO09ReKAf8x78PtZubxcvkpPovq77GRpfFqPN9/9qsc6hHlQJzulbwSElw8cUrTBx9Tb4DgEbqqOmBwdVPA1cRi7LlvoeZNQtGOM2UDEKVHNs9wprLZ8rXZluwBEY0aUoyesQ8q/BzG0VDHR5Cb+PjF07jkfPIcUaxiKkAdBJ6D+LtxKsrMAgtbMAYai8h7Ahu5JTefVLaOjTi+bKZv35cj+di+RoGP5Nyz4/blbXDN3y23lkbw6Fl8HOeRKfYrlInVfi6Ab7PqaZpTfrdsTjMMRHiRl/zokMFGN+YgsJ8VtqwRxF6arAFDuE0+p7y7ylhduNb+IpD0ZKNcrfLnSmRFvPCEy7LkkZz1nCPoHFK8k/VPepOujqx0fsVrVZ2y00XYtroVSQnXdZh8ajzEe1fFPdf2vLC0d0kqQBzw/hlWSY0= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa041bae-601f-42b6-0401-08d4dfb96c1c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR02MB3388; X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB3388;3:EQ6Jb3llazziTZ8S4OHoYyvBubZwlkFNUtHmi189R6iB4CFNiw65coGm+pS2ycbXNJJmMy57AUSbRLNtKDS0OtzPgqvV+nQz/OWS7dAYnrOJJGrnEsvKpm0B8BmxR92u69nhEMyMEM+sTVSf2Rck/F1BP89cY1FKjvXRGUgDHNNnnCmqPznJrMg416rTqG6FvybaxgqMy+Jt12qmPENebSm4yj9N8VmZAVvqHQjfPRyJcpPnA+TxCO0xL3H4o5acCM1p8AYXr2dm6vCN7Eb443n8bDQ+h6GtY6f420yOE6Pg4qSIbPtumJAPmlThrFV+WjQoXv+pn0JU5UEGIo4ePTca2epnhJmi/n+ZXv5iXsc=;25:CNDUjN5NCvQFIZq8KZJkzyoveAEtZklj8Q92vvhr19o7RSL3bR2XFcPRGP9vvDdQDSC6vbTqSsa9FIvSE+rpRyDXkqhHx/qzbChhv8C9iFKRBWlQIb3XuKHxfFD9VdWGTbXeaWP17FR3Ek+eK1SppX/UuHXu3FhlgAEmvA+gH+Dg6Ygy5j8iZ8nrwoGri9TK/3Gz3663ijMiEVD25cxrBkaTYnww6MIbGaNM+boReuECM77z5gBDYpjmByz0yDhQs/gKV8BHpkl+otF2MPC/TZ9ktaln9EtdSijYbJum8g0OLL8IOTxWXQOJdyXxaUEwGSffzD7Xy1SomhgKk31G/Q== X-MS-TrafficTypeDiagnostic: DM5PR02MB3388: X-LD-Processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB3388;31:8OI3T/An8t6ANluliP6taSPwTI4ct3BvEYioqqBQOGhh0HPIMEx/oC23eKSWQO2rwEzwvuGe6+D4WO98KzwTcmYVuJtODxTfLROna4ZhkVt/LIEryTO++rUfzajcgNJXfLmHWiRUcIrWTmh3e40f0CkktIp87v5sLt6i719iBrktuaNGrRiafHazhm9VkVXv4+92PyIC6a3N2iNvHQlAkA1VZ3Qg5gde/awaTWN7WaI=;20:rMbKyAu9q3yOq/uDiSmnjd0QB7lRybLAQ3SR9Gj3/j9qTUOnmoSaI5GvaIOicNGBOKqxzaKff3Re0fdEYG8bVzIWqnk//S2jwUMwXd7hvPL6eDgHFRjyeg2Job/1dr2SvgXh/EHmcsaT7i0kZ/qHIA5MQ37x4MMS0u6KvVcgQQ32REqmWge+VnhdMhe17jNeImAMmQMAcxdXjwXm1r/A2DK6VXMNQfKO/MVsmePUo6BCl4M2wNeIgrbtGEG5qcMFJoVK1k5Dj7xlv4khqhRdEUj9ENqCl6I/kv+cdW4O0BYzf2rM7tpfNH1Lwsl5BYpw3e0QQ49rq71o3yj0tLZMj87oMu8N9CMndZKG0z6QlgMOoeeEnsLEabh6EdxnINKh1ESlJLr/7R/YpocgJwJAhVlGliZkA2oimu8okJ8GFQrE0ORMPZxbQXQG7urgr6gVt8b8qNyNUgVwrL9+dk0bd8waJ4Ns77Ff4qI6pbeI3vQcTP5EKWM9hX7U98WZmw1p X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(13018025)(13016025)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93004095)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR02MB3388;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR02MB3388; X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB3388;4:a1x1WCNJbqPuYd8riQnkPOk3Rbhr750FPcDo149nhZVOhIWZV4xZVpbNFicI76PWMx6SbxWgmaARiMeOjMvqtHTW65wANujBNlnWLBOqvydkDnJRcbvbnE64Xzcaj9NC9UvMchSvWpKyVFxAeMp73cOgxtui4zYF1rBNCWMQgpkOHbNI+PUXk3tOLFheHJYiidajeMON8zGUi7Qm78aZqjBLhSwT4pNoY1Awa8Twus4sqvvdeAjBUVIKt9aqjjjiHKDPRFeSjA637wsz1m7biX/jcf5uJyPpTDIZav/9OUo= X-Forefront-PRVS: 03950F25EC X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjAyTUIzMzg4OzIzOmNmaW01cVpsTTZ5dFAweW5aU0cvdWJ6d3da?= =?utf-8?B?QWpTWVhTVG1iNW1YU0thUmo3eGZGMmJuU0g2ZlJNWW13OWxUbWpJZk1JR1pF?= =?utf-8?B?OXQ4UVc4ZFAxK1g3Qmc0UWpncS92eElmcTk0cmwxaHZGVWhvY0llSU5PWFNw?= =?utf-8?B?MnAyVzdSUHphTWpJVDc0b3NVTGtjVEl0UlU4WnpNZkFMZlQrNkNJQTE2c3Z0?= =?utf-8?B?UTI4OFVwSGtLbnpoNXdXbkVaOERaMmF4OWRDV1BIZ3kxZUQ1eW9GZldTRXIz?= =?utf-8?B?STNHZFhNNng0eFYvbElkaWY3M0VucGp1UEdNZnBiQWJsMWZyQWV5Sk1vVitu?= =?utf-8?B?Z20yTFBaYkYrdGRsc3B5WmpjZUJhdEtJUU9haW40Z00yKzIwWkxRVnM2MGNL?= =?utf-8?B?NXNWNXNnWkk2S0cwTUszSWZVMEEvaWVVSzhvODIycDZEb29ucDRBVy9sdkh2?= =?utf-8?B?WWlVdlh3aDJ5WEhtbzFiSStuSUhvQzV4dk45bm44Nmg0N1FtUTA4cDRzUGU5?= =?utf-8?B?MEpZckcvNEkrVXBmRnJjVHdncVBzYjY3RE5rR1RJeGIyUXFUMVNKM1VnUjhq?= =?utf-8?B?TWZnZ2RKQlcxMGo5TXRmUHh4dXV6N3BWZnR3d2hybWZSb0RXeW1NSG5xdkxY?= =?utf-8?B?SjdBdDBEd3J6UWpiUVdDTmVjenJwSS9iT0RjVDdNdEZ1bTNwNEgvdkxMOGlq?= =?utf-8?B?MEJ6ejkvNXJXaVVwaVJHVTVrdDRzblQ3d3gySlQwN29oOXZHbzk2ZnBKd3dp?= =?utf-8?B?TUxGR1R0aWxCVkMwNFNTbzd4UzM1T3pUYkpCeU00R042NDFEQlVGSzdoRlEz?= =?utf-8?B?NUpVN0dZN0k0R3ZMRjN2aUVzbzgwRitOWVRpc2JaT0N5amhQWVlhNXVYMWl6?= =?utf-8?B?enMvYlBuUlJ6N1FkUE1KMHJtcUo2cGlwaExvTTBTUjlvSzI4WHl0N0tJbTV0?= =?utf-8?B?R0FkR0hXY1J0ZGFEZjZXQUVTcWtGNWM2Vm80SGVaZlJmMUVsaXR3K0V5YVZw?= =?utf-8?B?V1JhZm1qSGhaVVhyS1B5bE05VFVlcHNGUXZYL1hTWlBHQVcyanFpNW9CSnNr?= =?utf-8?B?bWZobEViTHJVMDkvQTlqOVBQbkFpN0lUalRHQkJTc2s3Zm94WFZKcnN3bjlY?= =?utf-8?B?Q2dRbjZXTllpMUxQY1pGS3FGbEp4d2YzZTU2RU1qRm50OUhCUGM2cUlTS3pS?= =?utf-8?B?bE1LREc1c0FNT3hpVDN6RkFmbGFLNW8vcU94TmovZ0h0MUQrZVJCdUVLUUtu?= =?utf-8?B?cmF6NEJneWZPVGFuZVZSeHlvckNPWTNCbU5YUjU0UnlMeExwZU8xL1o1SzB4?= =?utf-8?B?eUNMdFBEODFna25mSG1EY2RDVE5abk9OL00wdjVkZmNaQTJkU0Z1a0R3QUlx?= =?utf-8?B?YVFVNXlyUjI0c0Uzekp4dlk3eGJZdllJWUJxaWVPekJoV2M3U2xLRDl3K1g4?= =?utf-8?B?cmlFeWJ3Q0NuS1QxY1M4N1dldVg5Wm5lMU9VR2FYS0F4NjFienVPbkV6U0l0?= =?utf-8?B?N0todFB0UFJZUi9ReDJoOW1MbXNRc3N6dUgrM0t6aFVKZWlFVDI2OHF2Njcx?= =?utf-8?B?Tm1jbGZXQkkyb2M2eFc2eW9Nanh1T05NYzV5clJrRVMyT3VrN3dBZE5PYXRp?= =?utf-8?B?a0paa2U4SVRTN1ZVUEI2YjdjZjlKQlFKcGxzdW9lamdoMWR5dTdqcm0vYzd2?= =?utf-8?B?OS9uc1JBdGNtditGMUJub2FCZWxOdko2V3c1Rm5lWk1wSjRSSTN2ZVlqT2py?= =?utf-8?B?dWUyS2ROdG5YRlcyZEp0SFhza2pGdnRSVnY2M1RtT1hzTXlISVB5dE16S0NG?= =?utf-8?B?UjFjQm5SNHJKWG5FRSs5MThaaXVsc0gzcVRtd1lmQ2gybkpKQjEwZ2hid1Ju?= =?utf-8?B?clBBTy9mR1Bwbm5uNEhZbTdBQjRkOHZCYmw1K05HcHYvMTZUTThJU0RrMnJJ?= =?utf-8?B?YUh5RHJvaG9nPT0=?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB3388;6:7nvLXS0J8GQb6h3BgmeOu1zXNMOHlgOUiXJGHNnb52DyoVaQ11uKvqhl5tJcpwhS3bw/ZKlISoTUkvl8NKtXyZrR4J40U+28I3Z5eTF2VxI+3/hXb34zk49b4QHbYWqgpgHadyro1xvqydDFXZY9U+7ruhKWO7sTNMlJpnR43KmtNghfqEg0EGcQocdbqvVyBnXdaq8MKkQnnB40T9hmJivQ480BeTbii06L39XBOdOsSceWlrCqdsv9JtEhjm8yAFO3tyWgJPLjPI63sNKf0LUrJ972JUoz2A8OTThtFEWgFezffcKQuorS2H0p1GLD6OchRmaZFiX7NiAuVkLiNA==;5:Tn/+Lbxcd4weDq63vvnVWXDPQ1kzNaCLfabo2rRE8wdfZwZao7PyVQXj4XKcLGWCQJTWzk4zeemuyBeVbAJYFb71hN0pU0RUYSoDWMYiezo8OS7uiiXGnCcuYjNFrlsTXO7wXzrHtOrowWNniZJvWw==;24:ovPUGG9FpGMeW92ysU/c1GyR22AxU7nHaflPgu6o9TrPGiODAExjrGY3avtC5ro7xLQYx4DfqMxcUS87qHJszivPmW1GCpOR4XpNlmjsVWg=;7:QDoLAkbtNsObGbKYsBzRPBk8ajK8mK4El53nKoQDMGkjVtHx7ZzOC8tN3W1FnV9HcVvb9/KT3119kbGGhQ9cVucEtgeGLXtG+x84DGEEP4rbEt6HMoGY/8/vc8mjoxOO5su+od2Nr4J2r/EtdXwnhthyNSVzkv0vTTLtZbFoD1Wiy94XcRJuv4RaMaXdBsIep7zs726vE0cEEPQVcbbkH1bPs2ccwcPZg1wvxTP/xVA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2017 06:31:23.9926 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB3388 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8.8.2017 17:52, Joe Perches wrote: > On Tue, 2017-08-08 at 14:04 +0200, Michal Simek wrote: >> From: Sai Krishna Potthuri > [] >> diff --git a/drivers/iio/adc/xilinx-xadc.h b/drivers/iio/adc/xilinx-xadc.h > [] >> @@ -76,7 +76,7 @@ struct xadc_ops { >> int (*setup)(struct platform_device *pdev, struct iio_dev *indio_dev, >> int irq); >> void (*update_alarm)(struct xadc *, unsigned int); >> - unsigned long (*get_dclk_rate)(struct xadc *); >> + unsigned long (*get_dclk_rate)(struct xadc *xadc); >> irqreturn_t (*interrupt_handler)(int, void *); > > Doesn't it seem odd to you that the lines above and below > have the same form? > > checkpatch is an imperfect tool. > It will always be imperfect. > Please use your eyes and mind too. You are right. I have missed that in internal review. Fixed in v2. Thanks, Michal