From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757154AbcLULSL (ORCPT ); Wed, 21 Dec 2016 06:18:11 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:57211 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934327AbcLULSF (ORCPT ); Wed, 21 Dec 2016 06:18:05 -0500 X-AuditID: cbfee61b-f79d86d00000197e-05-585a64ebcc91 From: Bartlomiej Zolnierkiewicz To: Kees Cook Cc: linux-kernel@vger.kernel.org, Tomi Valkeinen , Sudip Mukherjee , linux-fbdev@vger.kernel.org Subject: Re: [PATCH] video: use designated initializers Date: Wed, 21 Dec 2016 12:18:01 +0100 Message-id: <1614230.6oImxsjlZB@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20161217010309.GA140492@beast> References: <20161217010309.GA140492@beast> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsVy+t9jAd3XKVERBn/2CVqc6c61ONH3gdXi 8q45bBYHTk9htlg//xabA6vH7IaLLB47Z91l9zh+YzuTx+dNcgEsUW42GamJKalFCql5yfkp mXnptkqhIW66FkoKeYm5qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DL+PLsNXvBNuGK I69esjUwrhLoYuTkkBAwkZg14xsThC0mceHeerYuRi4OIYGljBJLD29jgXC+MkrsmPyTEaSK TcBKYmL7KjBbREBV4vulZmaQImaBqYwSp2dNBEsIC5hLbFu4mhnEZgEqmnn8LguIzSugKbF7 4iawGlEBL4kt+9rBVnMK6Ejc7PwIVi8koC2x8uUHdoh6QYkfk++B9TILyEvs2z+VFcLWkli/ 8zjTBEaBWUjKZiEpm4WkbAEj8ypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4Dh6Jr2D 8fAu90OMAhyMSjy8DhmREUKsiWXFlbmHGCU4mJVEeD8nR0UI8aYkVlalFuXHF5XmpBYfYjQF enAis5Rocj4wxvNK4g1NzE3MjQ0szC0tTYyUxHkbZz8LFxJITyxJzU5NLUgtgulj4uCUamA8 kFy/U5Z7zoWVQgoM7wXv5z35ICV49+XVWZl7H60uXtJ0OYo74dPs6tnzLeWld0nEqDjKsGp2 /LOe2bqMc9reD0F31qYvtU+6blq6ZBOnXMRLmUpe9QsH98QU6v+3uMCT4CvaoJF9sOtFwE3X Vs9c50lufefa9vfy+x5dudT6hcTOzVwKExqVWIozEg21mIuKEwHYYjy6uQIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ sent from the right account this time, sorry for duplicate mail ] Hi, On Friday, December 16, 2016 05:03:09 PM Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. Please: - fix patch subject line to "video: fbdev: matroxfb: ..." - align the two columns vertically while at it Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > Signed-off-by: Kees Cook > --- > drivers/video/fbdev/matrox/matroxfb_DAC1064.c | 10 ++++++++-- > drivers/video/fbdev/matrox/matroxfb_Ti3026.c | 5 ++++- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > index a01147fdf270..5d896f879ff9 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > +++ b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > @@ -1088,14 +1088,20 @@ static void MGAG100_restore(struct matrox_fb_info *minfo) > > #ifdef CONFIG_FB_MATROX_MYSTIQUE > struct matrox_switch matrox_mystique = { > - MGA1064_preinit, MGA1064_reset, MGA1064_init, MGA1064_restore, > + .preinit = MGA1064_preinit, > + .reset = MGA1064_reset, > + .init = MGA1064_init, > + .restore = MGA1064_restore, > }; > EXPORT_SYMBOL(matrox_mystique); > #endif > > #ifdef CONFIG_FB_MATROX_G > struct matrox_switch matrox_G100 = { > - MGAG100_preinit, MGAG100_reset, MGAG100_init, MGAG100_restore, > + .preinit = MGAG100_preinit, > + .reset = MGAG100_reset, > + .init = MGAG100_init, > + .restore = MGAG100_restore, > }; > EXPORT_SYMBOL(matrox_G100); > #endif > diff --git a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > index 68fa037d8cbc..0273351b2342 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > +++ b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > @@ -738,7 +738,10 @@ static int Ti3026_preinit(struct matrox_fb_info *minfo) > } > > struct matrox_switch matrox_millennium = { > - Ti3026_preinit, Ti3026_reset, Ti3026_init, Ti3026_restore > + .preinit = Ti3026_preinit, > + .reset = Ti3026_reset, > + .init = Ti3026_init, > + .restore = Ti3026_restore > }; > EXPORT_SYMBOL(matrox_millennium); > #endif