From: Marc Zyngier <maz@kernel.org>
To: Jia He <justin.he@arm.com>, kvmarm@lists.cs.columbia.edu
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH] KVM: arm64: Fix unaligned addr case in mmu walking
Date: Thu, 4 Mar 2021 09:55:30 +0000 [thread overview]
Message-ID: <161485171220.119036.4621661434944217679.b4-ty@kernel.org> (raw)
In-Reply-To: <20210303024225.2591-1-justin.he@arm.com>
On Wed, 3 Mar 2021 10:42:25 +0800, Jia He wrote:
> If the start addr is not aligned with the granule size of that level.
> loop step size should be adjusted to boundary instead of simple
> kvm_granual_size(level) increment. Otherwise, some mmu entries might miss
> the chance to be walked through.
> E.g. Assume the unmap range [data->addr, data->end] is
> [0xff00ab2000,0xff00cb2000] in level 2 walking and NOT block mapping.
> And the 1st part of that pmd entry is [0xff00ab2000,0xff00c00000]. The
> pmd value is 0x83fbd2c1002 (not valid entry). In this case, data->addr
> should be adjusted to 0xff00c00000 instead of 0xff00cb2000.
>
> [...]
Applied to fixes, thanks!
[1/1] KVM: arm64: Fix unaligned addr case in mmu walking
commit: e85583b3f1fe62c9b371a3100c1c91af94005ca9
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2021-03-04 9:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 2:42 Jia He
2021-03-03 9:54 ` Marc Zyngier
2021-03-03 11:08 ` Quentin Perret
2021-03-04 0:38 ` Justin He
2021-03-03 11:49 ` Will Deacon
2021-03-03 11:29 ` Will Deacon
2021-03-03 19:07 ` Marc Zyngier
2021-03-03 21:13 ` Will Deacon
2021-03-04 0:46 ` Justin He
2021-03-04 9:16 ` Marc Zyngier
2021-03-04 9:22 ` Will Deacon
2021-03-04 9:55 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161485171220.119036.4621661434944217679.b4-ty@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=justin.he@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®