From: Xu Yilun <yilun.xu@intel.com>
To: gregkh@linuxfoundation.org, mdf@kernel.org,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: trix@redhat.com, lgoncalv@redhat.com, yilun.xu@intel.com,
hao.wu@intel.com
Subject: [PATCH v12 0/2] UIO support for dfl devices
Date: Mon, 8 Mar 2021 09:59:34 +0800 [thread overview]
Message-ID: <1615168776-8553-1-git-send-email-yilun.xu@intel.com> (raw)
This patchset supports some dfl device drivers written in userspace.
There are some Q&A about why UIO driver is needed in v11:
From Greg:
Why are you saying that an ethernet driver should be using the UIO
interface?
And why can't you use the existing UIO drivers that bind to memory
regions specified by firmware? Without an interrupt being used, why is
UIO needed at all?
From Moritz:
Essentially I see two options:
- Have a DFL bus driver instantiate a platform driver (uio_pdrv_genirq)
which I *think* you described above?
- What this patch implements -- a UIO driver on the DFL bus
These FPGA devices can on the fly change their contents and -- even if
just for test -- being able to expose a bunch of registers via UIO can
be extremely useful.
Whether a device should expose registers or not should be up to the
implemeneter of the FPGA design I think (policy). This patch (or the
previous version) provides a mechanism to do so via DFL.
This is similar in nature to uio_pdrv_genirq on a DT based platform, to
expose the registers you instantiate the DT node.
Re-implementing a new driver for each of these instances doesn't seem
desirable and tying DFL as enumeration mechanism to UIO seems like a
good compromise for enabling this kind of functionality.
Note this is *not* an attempt to bypass the network stack or other
existing subsystems.
See the original message in:
https://lore.kernel.org/linux-fpga/YDvQ8aO8v3NhLKzx@epycbox.lan/T/#m66ba2c96848e3dea38d1a4f16dfea3cb291f7975
From Yilun:
The ETH GROUP IP is not designed as the full functional ethernet
controller. It is specially developed for the Intel N3000 NIC. Since it
is an FPGA based card, it is designed for the users to runtime reload
part of the MAC layer logic developed by themselves, while the ETH GROUP
is another part of the MAC which is not expected to be reloaded by
customers, but it provides some configurations for software to work with
the user logic.
So I category the feature as the devices that "designed for specific
purposes and does not fit into one of the standard kernel subsystems".
Some related description could be found in Patch #2, to illustrate why
using UIO for some DFL devices.
There are now UIO drivers for PCI or platform devices, but in this case
we are going to export a DFL(Device Feature List) bus device to
userspace, a DFL driver for UIO is needed to bind to it.
See the original message in:
https://lore.kernel.org/linux-fpga/YDvQ8aO8v3NhLKzx@epycbox.lan/T/#m91b303fd61485644353fad1e1e9c11d528844684
Xu Yilun (2):
uio: uio_dfl: add userspace i/o driver for DFL bus
Documentation: fpga: dfl: Add description for DFL UIO support
Documentation/fpga/dfl.rst | 26 ++++++++++++++++++
MAINTAINERS | 1 +
drivers/uio/Kconfig | 17 ++++++++++++
drivers/uio/Makefile | 1 +
drivers/uio/uio_dfl.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 111 insertions(+)
create mode 100644 drivers/uio/uio_dfl.c
--
2.7.4
next reply other threads:[~2021-03-08 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 1:59 Xu Yilun [this message]
2021-03-08 1:59 ` [PATCH v12 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus Xu Yilun
2021-03-08 1:59 ` [PATCH v12 2/2] Documentation: fpga: dfl: Add description for DFL UIO support Xu Yilun
2021-03-16 5:10 ` [PATCH v12 0/2] UIO support for dfl devices Xu Yilun
2021-03-28 12:58 ` Greg KH
2021-03-24 8:22 ` Xu Yilun
2021-03-24 21:17 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615168776-8553-1-git-send-email-yilun.xu@intel.com \
--to=yilun.xu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®