From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F849C433E0 for ; Tue, 9 Mar 2021 07:17:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4797D65295 for ; Tue, 9 Mar 2021 07:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229652AbhCIHMR (ORCPT ); Tue, 9 Mar 2021 02:12:17 -0500 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:41770 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbhCIHLs (ORCPT ); Tue, 9 Mar 2021 02:11:48 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R401e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UR3kFqb_1615273900; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UR3kFqb_1615273900) by smtp.aliyun-inc.com(127.0.0.1); Tue, 09 Mar 2021 15:11:46 +0800 From: Jiapeng Chong To: stefanr@s5r6.in-berlin.de Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] firewire: Use bitwise instead of arithmetic operator for flags Date: Tue, 9 Mar 2021 15:11:39 +0800 Message-Id: <1615273899-88446-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/firewire/core-device.c:973:22-23: WARNING: sum of probable bitmasks, consider |. ./drivers/firewire/core-device.c:954:22-23: WARNING: sum of probable bitmasks, consider |. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/firewire/core-device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c index 6821698..e04832d 100644 --- a/drivers/firewire/core-device.c +++ b/drivers/firewire/core-device.c @@ -951,7 +951,7 @@ static void set_broadcast_channel(struct fw_device *device, int generation) if (device->bc_implemented == BC_UNKNOWN) { rcode = fw_run_transaction(card, TCODE_READ_QUADLET_REQUEST, device->node_id, generation, device->max_speed, - CSR_REGISTER_BASE + CSR_BROADCAST_CHANNEL, + CSR_REGISTER_BASE | CSR_BROADCAST_CHANNEL, &data, 4); switch (rcode) { case RCODE_COMPLETE: @@ -970,7 +970,7 @@ static void set_broadcast_channel(struct fw_device *device, int generation) BROADCAST_CHANNEL_VALID); fw_run_transaction(card, TCODE_WRITE_QUADLET_REQUEST, device->node_id, generation, device->max_speed, - CSR_REGISTER_BASE + CSR_BROADCAST_CHANNEL, + CSR_REGISTER_BASE | CSR_BROADCAST_CHANNEL, &data, 4); } } -- 1.8.3.1