From: "tip-bot2 for Edmundo Carmona Antoranz" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Edmundo Carmona Antoranz <eantoranz@gmail.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched: Remove unnecessary variable from schedule_tail()
Date: Wed, 10 Mar 2021 11:26:20 -0000 [thread overview]
Message-ID: <161537558015.398.4747038691034454737.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210306210739.1370486-1-eantoranz@gmail.com>
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 13c2235b2b2870675195f0b551275d1abdd81068
Gitweb: https://git.kernel.org/tip/13c2235b2b2870675195f0b551275d1abdd81068
Author: Edmundo Carmona Antoranz <eantoranz@gmail.com>
AuthorDate: Sat, 06 Mar 2021 15:07:39 -06:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 10 Mar 2021 09:51:49 +01:00
sched: Remove unnecessary variable from schedule_tail()
Since 565790d28b1 (sched: Fix balance_callback(), 2020-05-11), there
is no longer a need to reuse the result value of the call to finish_task_switch()
inside schedule_tail(), therefore the variable used to hold that value
(rq) is no longer needed.
Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20210306210739.1370486-1-eantoranz@gmail.com
---
kernel/sched/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index d2629fd..28c4df6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4253,8 +4253,6 @@ static struct rq *finish_task_switch(struct task_struct *prev)
asmlinkage __visible void schedule_tail(struct task_struct *prev)
__releases(rq->lock)
{
- struct rq *rq;
-
/*
* New tasks start with FORK_PREEMPT_COUNT, see there and
* finish_task_switch() for details.
@@ -4264,7 +4262,7 @@ asmlinkage __visible void schedule_tail(struct task_struct *prev)
* PREEMPT_COUNT kernels).
*/
- rq = finish_task_switch(prev);
+ finish_task_switch(prev);
preempt_enable();
if (current->set_child_tid)
parent reply other threads:[~2021-03-10 11:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210306210739.1370486-1-eantoranz@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161537558015.398.4747038691034454737.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=eantoranz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®