Re: [PATCH v3 2/2] arm64: dts: Add support for Kontron i.MX93 OSM-S SoM and BL carrier board

[Frieder Schrempf <frieder.schrempf@kontron.de>]

On 06.08.24 4:54 PM, Peng Fan wrote:
>> Subject: Re: [PATCH v3 2/2] arm64: dts: Add support for Kontron
>> i.MX93 OSM-S SoM and BL carrier board
>>
>> Hi Peng,
>>
>> thanks for reviewing!
>>
>> On 01.08.24 4:10 AM, Peng Fan wrote:
>>>> Subject: [PATCH v3 2/2] arm64: dts: Add support for Kontron
>> i.MX93
>>>> OSM-S SoM and BL carrier board
>>>>
>>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>>
>>>> This adds support for the Kontron Electronics OSM-S i.MX93 SoM
>> and
>>>> the matching baseboard BL i.MX93.
>>>>
>>>> The SoM hardware complies to the Open Standard Module (OSM)
>> 1.1
>>>> specification, size S
>>>>
>>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>> ---
>>>>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>>>>  .../dts/freescale/imx93-kontron-bl-osm-s.dts  | 165 ++++++
>>>>  .../dts/freescale/imx93-kontron-osm-s.dtsi    | 547
>>>> ++++++++++++++++++
>>>>  3 files changed, 713 insertions(+)
>>>>  create mode 100644 arch/arm64/boot/dts/freescale/imx93-
>> kontron-
>>>> bl-osm-s.dts
>>>>  create mode 100644 arch/arm64/boot/dts/freescale/imx93-
>> kontron-
>>>> osm-s.dtsi
>>>>
>>>> diff --git a/arch/arm64/boot/dts/freescale/Makefile
>>>> b/arch/arm64/boot/dts/freescale/Makefile
>>>> index f04c22b7de72e..c6e82dfe37576 100644
>>>> --- a/arch/arm64/boot/dts/freescale/Makefile
>>>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>>>> @@ -238,6 +238,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8qxp-
>>>> tqma8xqp-mba8xx.dtb
>>>>  dtb-$(CONFIG_ARCH_MXC) += imx8ulp-evk.dtb
>>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb.dtb
>>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
>>>> +dtb-$(CONFIG_ARCH_MXC) += imx93-kontron-bl-osm-s.dtb
>>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb
>>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxca.dtb
>>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb diff
>> -- git
>>>> a/arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dts
>>>> b/arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dts
>>>> new file mode 100644
>>>> index 0000000000000..2dfa2381f4691
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dts
>>>> @@ -0,0 +1,165 @@
>>>> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
>>>> +/*
>>>> + * Copyright (C) 2024 Kontron Electronics GmbH  */
>>>> +
>>>> +/dts-v1/;
>>>> +
>>>> +#include "imx93-kontron-osm-s.dtsi"
>>>> +
>>>> +/ {
>>>> +	model = "Kontron BL i.MX93 OSM-S";
>>>> +	compatible = "kontron,imx93-bl-osm-s", "kontron,imx93-osm-
>>>> s",
>>>> +"fsl,imx93";
>>>> +
>>>> +	aliases {
>>>> +		ethernet0 = &fec;
>>>> +		ethernet1 = &eqos;
>>>> +	};
>>>> +
>>>> +	leds {
>>>> +		compatible = "gpio-leds";
>>>> +
>>>> +		led1 {
>>>> +			label = "led1";
>>>> +			gpios = <&gpio2 3 GPIO_ACTIVE_HIGH>;
>>>> +			linux,default-trigger = "heartbeat";
>>>> +		};
>>>> +	};
>>>> +
>>>> +	pwm-beeper {
>>>> +		compatible = "pwm-beeper";
>>>> +		pwms = <&tpm6 1 5000 0>;
>>>> +	};
>>>> +
>>>> +	reg_vcc_panel: regulator-vcc-panel {
>>>> +		compatible = "regulator-fixed";
>>>> +		enable-active-high;
>>>> +		gpio = <&gpio4 3 GPIO_ACTIVE_HIGH>;
>>>
>>> "enable-active-high" should be put under gpio property.
>>
>> Hm, alphabetically 'e' comes before 'g'. And I see a lot of occurences in
>> the tree where the order is like this. So I'm not really convinced it
>> should be the other way round.
> 
> I just take comments here:
> https://lore.kernel.org/all/Zm+Mu33s2+8G579d@dragon/

Ok, if Shawn likes it that way, I will change it ;)
Thanks!