From: Hui Tang <tanghui20@huawei.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-crypto@vger.kernel.org>, <xuzaibo@huawei.com>,
<wangzhou1@hisilicon.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] crypto: hisilicon/hpre - optimise 'hpre_algs_register' error path
Date: Fri, 19 Mar 2021 18:44:19 +0800 [thread overview]
Message-ID: <1616150659-10756-3-git-send-email-tanghui20@huawei.com> (raw)
In-Reply-To: <1616150659-10756-1-git-send-email-tanghui20@huawei.com>
There is redundant code especially when registing new algorithms
in the future.
Signed-off-by: Hui Tang <tanghui20@huawei.com>
---
drivers/crypto/hisilicon/hpre/hpre_crypto.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
index 50ccd10..b77473b 100644
--- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
+++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
@@ -1993,25 +1993,24 @@ int hpre_algs_register(struct hisi_qm *qm)
return ret;
ret = crypto_register_kpp(&dh);
- if (ret) {
- crypto_unregister_akcipher(&rsa);
- return ret;
- }
+ if (ret)
+ goto unreg_rsa;
if (qm->ver >= QM_HW_V3) {
ret = hpre_register_ecdh();
if (ret)
- goto reg_err;
+ goto unreg_dh;
ret = crypto_register_kpp(&curve25519_alg);
- if (ret) {
- hpre_unregister_ecdh();
- goto reg_err;
- }
+ if (ret)
+ goto unreg_ecdh;
}
return 0;
-reg_err:
+unreg_ecdh:
+ hpre_unregister_ecdh();
+unreg_dh:
crypto_unregister_kpp(&dh);
+unreg_rsa:
crypto_unregister_akcipher(&rsa);
return ret;
}
--
2.8.1
next prev parent reply other threads:[~2021-03-19 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 10:44 [PATCH 0/2] crypto: hisilicon/hpre - remove 'CONFIG_CRYPTO_DH' Hui Tang
2021-03-19 10:44 ` [PATCH 1/2] crypto: hisilicon/hpre - delete wrap of 'CONFIG_CRYPTO_DH' Hui Tang
2021-03-19 10:44 ` Hui Tang [this message]
2021-03-26 9:32 ` [PATCH 0/2] crypto: hisilicon/hpre - remove 'CONFIG_CRYPTO_DH' Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616150659-10756-3-git-send-email-tanghui20@huawei.com \
--to=tanghui20@huawei.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®